Skip to content

MQE-1236 #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 31, 2018
Merged

MQE-1236 #218

merged 4 commits into from
Aug 31, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Changed AnnotationExtractor to automatically prepend testCaseId to the title annotation, and added a check for uniqueness of testCaseId to title annotation.
  • All of this is to prevent Allure from overwriting (calling duplicate titles retries)

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1236: Allure Does Not Show Results For Tests With Duplicate Title…
083c3d2 
… Annotation

- TestCaseID is not prepended to Test Title (or placeholder if none are found
- Story/Title Annotation validation also reworked to include tests that contain no stories.
@KevinBKozan
MQE-1236: Allure Does Not Show Results For Tests With Duplicate Title…
40798b8 
… and Annotation

- Unit/Verification test updates
@KevinBKozan
MQE-1236: Allure Does Not Show Results For Tests With Duplicate Title…
aa3578b 
… and Annotation

- Renamed variables in function to reflect use
@coveralls
Copy link

coveralls commented Aug 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 57.151% when pulling 4d06662 on MQE-1236 into e187c33 on develop.

jilu1
jilu1 reviewed Aug 31, 2018
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and QAed. All look good. Minor comments on some cosmetic problem.

@KevinBKozan
MQE-1236: Allure Does Not Show Results For Tests With Duplicate Title
4d06662 
- CR fixes, changing delimiter from ` - ` to `: `
@KevinBKozan KevinBKozan merged commit 9acb400 into develop Aug 31, 2018
@KevinBKozan KevinBKozan deleted the MQE-1236 branch August 31, 2018 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljcalandra aljcalandra Awaiting requested review from aljcalandra

1 more reviewer

@jilu1 jilu1 jilu1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @jilu1