Skip to content

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2018
Merged

MQE-1142: Use timeout value when waitForLoadingMaskToDisappear #230

merged 1 commit into from
Sep 20, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Added default value for $timeout attribute (causing issues with CE tests)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1142: Use timeout value when waitForLoadingMaskToDisappear
bc0e154 
- Added default value for $timeout attribute (causing issues with CE tests)
@KevinBKozan KevinBKozan requested a review from jilu1 September 19, 2018 18:27
jilu1
jilu1 approved these changes Sep 19, 2018
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.398% when pulling bc0e154 on MQE-1142-Fix into 66b6ecd on develop.

@KevinBKozan KevinBKozan merged commit 214abd7 into develop Sep 20, 2018
@KevinBKozan KevinBKozan deleted the MQE-1142-Fix branch September 20, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jilu1 jilu1 jilu1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @jilu1