MQE-1279: MFTF will not output any test results if instance respondes…

[jilu1]

… with 503

• fix error handling to simplify stack trace

Description

Fixed Issues (if relevant)

1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
2. ...

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/verification tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)
• Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

[coveralls]

Coverage increased (+0.008%) to 57.4% when pulling 4ed8b0a on MQE-1279 into bf7ea22 on develop.

[KevinBKozan]

Changes don't really help the root issue. In the build, this will still cause a silent failure, as this is run before the entire suite (or test), meaning no failure artifacts are recorded at all.

I tried removing this file from functional.suite.yml and found that it solves the issue entirely; the magento instance is unavailable but the test starts properly and fails naturally due to the instance being in maintenance mode.
Can we remove the reference to MagentoRestDriver from functional.suite.yml entirely? I think this is old unused code.

[jilu1]

I disabled MagentoRestDriver, run functional test builds and it looks fine.

Although it does not make sense for silent failure in Jenkins as an exception is thrown either from Codeception or MFTF framework. Still Jenkins pipeline issue?

[KevinBKozan]

Jenkins runs codecept run statements with || true, meaning it never uses the codeception exit code (or the MagentoRestDriver exception in this case) to determine failure, it only uses existance of test artifacts.

[KevinBKozan]

Change looks good and works, but I think the last thing we should do is remove MagentoRestDriver.php from the codebase (to not keep dead code around).