Skip to content

Fix Element with no type attribute warnings #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2018
Merged

Fix Element with no type attribute warnings #263

merged 2 commits into from
Nov 1, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • If an element has no type, it will cause a warning if it's parsed during a test run. This will lead to the test execution being aborted due to this warning, and thus no test artifacts.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
Fix Element with no type warning
566549c 
- Added ternary to $elementType assignment.
@KevinBKozan
Fix Element with no type warning
ea11032 
- Changelog update to reflect bugfix.
@KevinBKozan KevinBKozan requested a review from jilu1 November 1, 2018 18:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 57.403% when pulling ea11032 on Element-Type-Fix into 40f2cf8 on develop.

@KevinBKozan KevinBKozan merged commit a9e04a7 into develop Nov 1, 2018
@KevinBKozan KevinBKozan deleted the Element-Type-Fix branch November 1, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jilu1 jilu1 jilu1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @jilu1