Skip to content

MQE-1372: If Suite before fails build must be RED #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2018
Merged

MQE-1372: If Suite before fails build must be RED #284

merged 4 commits into from
Dec 6, 2018

Conversation

KevinBKozan
Copy link
Contributor

Description

  • Removed use of Codeception\Extension\RunFailed
  • Moved RunFailed functionality to TestContextExtension, to be able to write incomplete tests to the failed file (for build reasons)
  • Incomplete tests are now set as failed in MagentoAllureAdapter

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1372: If Suite before fails build must be RED
bbbad04 
- Added testIncomplete override to allure adapter, will mark incomplete tests as failed
- Lifted runFailed functionality from extension into TestContextExtension to be able to write incomplete tests to the failed fail
- Removed runFailed exception from etc version of Codeception.yml
@KevinBKozan
MQE-1372: If Suite before fails build must be RED
b60702d 
- Unit/static fixes
@KevinBKozan
Merge branch 'develop' into MQE-1372
4539159
@KevinBKozan
MQE-1372: If Suite before fails build must be RED
6e541da 
- Fixed writing of blank file if nothing failed
jilu1
jilu1 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Reviewed by Alex and me.

@KevinBKozan KevinBKozan merged commit bf2143d into develop Dec 6, 2018
@KevinBKozan KevinBKozan deleted the MQE-1372 branch December 6, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jilu1 jilu1 jilu1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KevinBKozan @jilu1 @okolesnyk @magento-engcom-team