Skip to content

#568 Project-based URN path generation + add consistency of misc.xml path #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

#568 Project-based URN path generation + add consistency of misc.xml path #570

merged 2 commits into from
Mar 23, 2020

Conversation

lbajsarowicz
Copy link
Contributor

Description

  1. Now you should provide path to .idea/misc.xml instead of just containing directory
  2. If you installed MFTF using Composer, your paths will be based on Project Root instead of absolute path.

Fixed Issues (if relevant)

  1. Bug: PHPStorm URN catalog generated with absolute paths + inconsistent behavior #568

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Mediotype partners-contribution Pull Request is created by Magento Partner labels Jan 31, 2020
@coveralls
Copy link

coveralls commented Jan 31, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 53.766% when pulling a734abb on lbajsarowicz:bugfix/568-urn-catalog into d82e6cf on magento:develop.

@okolesnyk okolesnyk merged commit 65bd46c into magento:develop Mar 23, 2020
@lbajsarowicz lbajsarowicz mentioned this pull request Jun 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okolesnyk okolesnyk okolesnyk approved these changes

Assignees
No one assigned
Labels
Partner: Mediotype partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbajsarowicz @coveralls @okolesnyk @magento-engcom-team