Skip to content

MQE-1799: Throw exception during generation when leaving out .url for amOnPage #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 11, 2020
Merged

MQE-1799: Throw exception during generation when leaving out .url for amOnPage #618

merged 7 commits into from
Mar 11, 2020

Conversation

tomreece
Copy link
Contributor

@tomreece tomreece commented Mar 6, 2020 •
edited
Loading

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 50.89% when pulling 34456fa on MQE-1799 into 32e7600 on develop.

@coveralls
Copy link

coveralls commented Mar 6, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 50.556% when pulling 8cf81e2 on MQE-1799 into 65919fe on develop.

@tomreece tomreece mentioned this pull request Mar 8, 2020
Merged
5 tasks
KevinBKozan
KevinBKozan reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change look good, but I did notice one thing: it does not cover the usecase:
url="{{page}}/subdomain" or `"url="{{page}}/{{otherpage}}"

I'm not 100% sure if this is a common occurence in the framework, but I do know it's possible for amOnUrl

@tomreece tomreece merged commit bedde57 into develop Mar 11, 2020
@tomreece tomreece deleted the MQE-1799 branch April 30, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomreece @coveralls @KevinBKozan