Skip to content

Getting started > Removing code snippet #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Getting started > Removing code snippet #639

merged 1 commit into from
Apr 23, 2020

Conversation

rafaelstz
Copy link
Member

Description

I removed an unnecessary code snippet which doesn't make sense where it's.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@rafaelstz
Getting started > Removing code snippet
65fa3cc 
I removed an unnecessary code snippet which doesn't make sense where it's.
@magento-engcom-team magento-engcom-team added Partner: Le Site partners-contribution Pull Request is created by Magento Partner labels Mar 12, 2020
@coveralls
Copy link

coveralls commented Mar 12, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 51.005% when pulling 65fa3cc on rafaelstz:patch-3 into 7327be1 on magento:master.

@okolesnyk okolesnyk requested a review from dobooth March 18, 2020 21:54
@okolesnyk okolesnyk merged commit 757e136 into magento:master Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dobooth dobooth dobooth approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
DOC Partner: Le Site partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rafaelstz @coveralls @dobooth @okolesnyk @magento-engcom-team