Skip to content

MQE-2043 Custom helper argument in action group is not resolved #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2020
Merged

MQE-2043 Custom helper argument in action group is not resolved #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f62b8
MQE-2043: Custom helper argument in action group is not resolved
okolesnyk Apr 1, 2020
a879839
Merge branch 'MFTF3.0.0-RC2' into MQE-2043
okolesnyk Apr 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions dev/tests/functional/tests/MFTF/DevDocs/ActionGroup/HelperActionGroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@
<actionGroup name="HelperActionGroup">
<arguments>
<argument name="test" type="string" />
<argument name="entityTest" type="entity" />
</arguments>
<comment userInput="Action group to demonstrate helper functionality available from action groups." stepKey="comment" />
<helper class="\MFTF\DevDocs\Helper\CustomHelper" method="goTo" stepKey="customHelper">
<argument name="test">{{contentSection.parametrizedSelector(test)}}</argument>
<argument name="module">['{{test}}', 'Bla']</argument>
<argument name="test">{{contentSection.parametrizedSelector(entityTest.entityField)}}</argument>
<argument name="module">['{{entityTest.entityField}}', 'Bla']</argument>
<argument name="url">{{test}}</argument>
<argument name="bool">true</argument>
<argument name="float">4.400000000234234</argument>
Expand Down
1 change: 1 addition & 0 deletions dev/tests/functional/tests/MFTF/DevDocs/Test/DevDocsTest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@

<actionGroup ref="HelperActionGroup" stepKey="actionGroupWithCustomHelper">
<argument name="test" value="{{HelperData.entityField}}" />
<argument name="entityTest" value="HelperData" />
</actionGroup>
</test>
</tests>
3 changes: 3 additions & 0 deletions src/Magento/FunctionalTestingFramework/Test/Objects/ActionGroupObject.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@ private function getResolvedActionsWithArgs($arguments, $actionReferenceKey)
foreach ($this->parsedActions as $action) {
$replacementStepKeys[$action->getStepKey()] = $action->getStepKey() . ucfirst($actionReferenceKey);
$varAttributes = array_intersect($this->varAttributes, array_keys($action->getCustomActionAttributes()));
if ($action->getType() === ActionObject::ACTION_TYPE_HELPER) {
$varAttributes = array_keys($action->getCustomActionAttributes());
}

// replace createDataKey attributes inside the action group
$resolvedActionAttributes = $this->replaceCreateDataKeys($action, $replacementStepKeys);
Expand Down