Pangolins Sprint 11 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) is inside $$ signs
- Added check for syntax of $data.key[index]$, if so generates line like "$data.getCreatedData('key')['index']
…) is inside $$ signs - Reverted most changes and just kept regex change to accomodate [].
…ork file - Add copyright-check, a bash script to check for the Magento copyright in all tracked files - Fix various missing or incorrect copyrights
…ork file - Add composer-git-hooks dependency
…d supporting interpretation
- add new suite objects, handler, parser classes
- alter di.xml file to include new suite parsing
- add new resolver for root level dir
- change cest objects and test generators to fit with suite design
…d supporting interpretation - fix for codesniff tests
* MQE-418: [Generator] Quote issue in generator for parameterArray - Removed all processing of parameterArray, as current implementation was causing the errors. - Simple setting fixes all known usecases for the parameterArray attribute. - Merged and Reverted erroneous merge.
…args - ActionGroupObject now correctly handles $datakey$ references. - Fixed in-line doc to match structure. - Code Review changes for comments.
- add param for config flag and env to TestManifest Constructor
- change generate tests signature for new flags
…ta object type's key attribute. - fixed array reference to key instead of type when building request data
…ork file - Add copyright to more files that were recently added
…ork file - Refactor, rename, add comment to blacklist file
…ork file - Add copyright to copyright-check
- add verification and unit test structure
- add verification and unit tests
- add test utils
- add bootstrap setup file and phpunit.xml configuration
- change object handler classes to trigger notices for missing xml
…ta object type's key attribute.
- fixed array reference to key instead of type when building request data
…ork file - Adding copyright to a file which made it to sprint-develop before this task.
- ActionGroupObject now correctly handles $datakey$ references. - Refactoring of existing methods, creation of new methods to consolidate code.
- changed regex to accept all characters, not inside $data.ref$ and 'string literal` parameters.
- add new before/after tags - add new Group generator class - add verification test for new suite logic - update existing suite sample file
- fixes from code review feedback
- add Group object dir to .gitignore
- missed copyright tag
okolesnyk
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
Related Pull Requests
https://github.com/magento/magento2ce/pull/1615
https://github.com/magento/magento2ee/pull/760