Fix an issue with extended data array entity #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jilu1
suggested changes
Jun 3, 2020
| @@ -48,8 +48,8 @@ | |||
| </actionGroup> | |||
|
|
|||
| <assertEqualsCanonicalizing stepKey="assertMergedArray"> | |||
| <actualResult type="array">{{MessageData.numbers}}</actualResult> | |||
| <expectedResult type="array">["Something New", "0", "1", "2", "3"]</expectedResult> | |||
| <actualResult type="array">{{ExtendedMessageData.numbers}}</actualResult> | |||
There was a problem hiding this comment.
Can we keep the original MessageData assertion and add a new assertion for ExtendedMessageData so that we don't lose test coverage of the previous fix?
There was a problem hiding this comment.
I don't think we lose it.
In 1 assertion we cover both.
Because MessageData gets merged and then on top of it we merge ExtendedMessageData.numbers
There was a problem hiding this comment.
This is not a big deal. I am ok with either way.
jilu1
reviewed
Jun 3, 2020
jilu1
reviewed
Jun 3, 2020
|
Build with this branch https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/33394/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed Issues (if relevant)
Contribution checklist