Issue 33296: Eliminate AspectMock from OperationDataArrayResolverTest #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
partners-contribution
bohdan-harniuk
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Hello, @karyna-tsymbal-atwix!
Thank you for your work here!
Hello, @jilu1!
This task was finished without creating new singletons, so it is not a blocker. You can proceed with the code review.
Thanks, Bohdan
andrewbess
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Hello @karyna-tsymbal-atwix
Thank you for your contribution.
It looks well for me.
5 tasks
5 tasks
eduard13
approved these changes
Aug 4, 2021
jilu1
approved these changes
Aug 4, 2021
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
karyna-tsymbal-atwix
deleted the
improvement/mftf-33296-eliminate-aspect-mock-from-operation-data-array-resolver-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminated AspectMock usage from
dev/tests/unit/Magento/FunctionalTestFramework/DataGenerator/Persist/OperationDataArrayResolverTest.phpFixed Issues (if relevant)
Contribution checklist