Improvement/mftf 33584 eliminate aspect mock from object handler uti #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generator-test' of github.com:anzin/magento2-functional-testing-framework into improvement/mftf-33583-eliminate-aspect-mock-from-mock-module-resolver-builder
…ject-handler-test' of github.com:bohdan-harniuk/magento2-functional-testing-framework into improvement/mftf-33583-eliminate-aspect-mock-from-mock-module-resolver-builder
…ject-handler-test' of github.com:bohdan-harniuk/magento2-functional-testing-framework into improvement/mftf-33584-eliminate-aspect-mock-from-object-handler-uti
…t' of github.com:anzin/magento2-functional-testing-framework into improvement/mftf-33584-eliminate-aspect-mock-from-object-handler-uti
…sted-object-handler-test' of github.com:anzin/magento2-functional-testing-framework into improvement/mftf-33584-eliminate-aspect-mock-from-object-handler-uti
…module-resolver-builder' of github.com:bohdan-harniuk/magento2-functional-testing-framework into improvement/mftf-33584-eliminate-aspect-mock-from-object-handler-uti
magento-engcom-team
added
Partner: Atwix
partners-contribution
andrewbess
previously approved these changes
Jul 28, 2021
There was a problem hiding this comment.
Hello @anzin
Thank you for your contribution.
Changes look well for me.
|
Hi @anzin |
okolesnyk
requested changes
Aug 2, 2021
…ock-from-object-handler-uti
eduard13
previously approved these changes
Aug 3, 2021
Hello @okolesnyk, thanks for the review I will resolve conflicts when all related PRs will be merged. Thanks. |
…ing-framework into improvement/mftf-33584-eliminate-aspect-mock-from-object-handler-uti
5 tasks
andrewbess
approved these changes
Aug 11, 2021
|
@magento import pull request to https://github.com/magento-commerce/magento2-functional-testing-framework |
|
@jilu1 the pull request successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've eliminated AspectMock usage for the
dev/tests/unit/Util/ObjectHandlerUtil.php.Fixed Issues (if relevant)
Into this branch was merged the next PRs (this PR relates to them and has code changes in the files changed in that PRs):
Related Pull Requests:
#844
#862
#853
#861
Contribution checklist