Skip to content

magento/magento2-page-builder#504: Mismatching Strict Type #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

magento/magento2-page-builder#504: Mismatching Strict Type #528

wants to merge 2 commits into from

Conversation

bluemwhitew
Copy link
Contributor

Description (*)

Fixed an inconsistency where strict types that were not present in the original method were being applied.

Fixed Issues

  1. https://www.github.com/magento/magento2-page-builder/issues/504

Builds

N/A

Related Pull Requests

N/A

Manual Testing Scenarios (*)

N/A

Questions or Comments

N/A

Checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@bluemwhitew
#504: Mismatching Strict Type
502cb17 
- Extending Integration Test
@bluemwhitew
#504: Mismatching Strict Type
040827a 
- Adding Null Coalescing Operator
- Removing Strict Type from `$result` Parameter (Cheers, @dannynimmo)
@bluemwhitew
Copy link
Contributor Author

@magento run all tests

@bluemwhitew bluemwhitew linked an issue Jun 10, 2020 that may be closed by this pull request
"Magento\PageBuilder\Plugin\Filter\TemplatePlugin" mismatching strict type #504
Closed
@ghost ghost added 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: 2.4-develop: 3️⃣ 2.4-develop: :three: 2.4-develop: 2️⃣ 2.4-develop: :two: and removed 2.4-develop: 5️⃣ 2.4-develop: :five: 2.4-develop: 4️⃣ 2.4-develop: :four: 2.4-develop: 3️⃣ 2.4-develop: :three: labels Jun 11, 2020
@omiroshnichenko omiroshnichenko added the 2.4-develop: exclude 2.4-develop: exclude label Jun 11, 2020
@ghost ghost removed the 2.4-develop: 2️⃣ 2.4-develop: :two: label Jun 11, 2020
@bluemwhitew
Copy link
Contributor Author

Closing PR. See #504 for further information.

@omiroshnichenko omiroshnichenko deleted the 504_mismatching-strict-type branch July 20, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

Assignees

@omiroshnichenko omiroshnichenko

Labels
2.4-develop: exclude 2.4-develop: exclude Progress: approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Magento\PageBuilder\Plugin\Filter\TemplatePlugin" mismatching strict type
2 participants
@bluemwhitew @omiroshnichenko