#637: Form field/field group viewport scope - icon and tooltip #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ope - added icon and tooltip on hover and applied styling
|
@magento run all tests |
…ope - added mobile icon and finalized styling
…ope - adjusted min height width
…ope - added styling for mobile icon tooltip with min height fields that contain notice and without notice
|
@magento run all tests |
…gento2-page-builder into 637-form-field-viewport-scope-icon-tooltip-content-type
…ope - additional classes for minimum height form field
|
@magento run all tests |
…gento2-page-builder into 637-form-field-viewport-scope-icon-tooltip-content-type
…ope - applied mobile icon and tooltip to all content types
|
@magento run all tests |
yolouiese
changed the title
m2-community-project
bot
added
Progress: ready for review
and removed
Progress: work in progress
labels
m2-community-project
bot
added
Progress: review
Progress: ready for review
and removed
Progress: ready for review
Progress: review
labels
| @@ -0,0 +1,8 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" width="10" height="18" viewBox="0 0 10 18"> | |||
There was a problem hiding this comment.
Please, add this icon as a part of pagebuilder-icon fonts using IcoMoon App. More details https://devdocs.magento.com/guides/v2.3/frontend-dev-guide/css-topics/using-fonts.html?itm_source=devdocs&itm_medium=search_page&itm_campaign=federated_search&itm_term=fonts%20svg
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
|
|
||
| .admin__field-tooltip-action { | ||
| &:before { | ||
| content: url("@{baseDir}Magento_PageBuilder/css/images/form/element/mobile-icon.svg"); |
There was a problem hiding this comment.
Create a variable with font code and replace url with variable here
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
…ope - fixed less related failures
|
@magento run all tests |
…ope - added mobile icon to PageBuilder icon fonts using IcoMoon app and adjusted styling for the mobile icon
…ope - adjusted mobile icon styling
|
@magento run all tests |
…ope - deleted the mobile icon svg
|
@magento run all tests |
m2-community-project
bot
added
Progress: ready for review
and removed
Progress: changes requested
labels
omiroshnichenko
approved these changes
Nov 11, 2020
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added the mobile icon and tooltip to min height form field.
The icon and tooltip have been implemented to the following content types:
Story
Checklist