Skip to content

[Team 3] Video Enhancements #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 67 commits into from
Jun 20, 2018
Merged

[Team 3] Video Enhancements #84

merged 67 commits into from
Jun 20, 2018

Conversation

irenelagno
Copy link
Contributor

@irenelagno irenelagno commented Jun 15, 2018

Scope

Story

Task

Bug

  • MC-2224 Removed Fonts in Mainline Cause Integration Test Failure

Bamboo CI Builds

Related Pull Requests

https://github.com/magento/magento2b2b/pull/421

Jenkins

https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/257/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/268/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/279/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/311/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/317/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/322/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/327/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/354/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/364/
https://m2build-ur.devops.magento.com/job/All-User-Requested-Tests/371/

Checklist

  • PR is green on M2 Quality Portal
  • Jira issues have accurate summary, meaningful description and have links to relevant documentation at the story/task level
  • Semantic Version build failure is approved by architect (if build is red)
  • Pull Request approved by architect
  • Pull Request quality review performed by
  • All unstable functional acceptance tests are isolated (if any)
  • All linked Zephyr tests are approved by PO and have Ready to Use status
  • Travis CI build is green (for mainline CE only)
  • Jenkins Extended FAT build is green

irenelagno and others added 30 commits June 8, 2018 10:00
- Video now maintains a 16:9 aspect ratio and obeys the max-width setting
- Max-width and max-height are now controlled via a mass-converter
- Added converter for video to use flex for alignment
- Removed reference to prototype
- Fixed issue with preview styles
- Refactored tabs, row, and maps to use new extensibility
…-trigger/magento2-page-builder into MAGETWO-86673-frontend-rendering
- build stabilization
- build stabilization
@irenelagno
Copy link
Contributor Author

Remove references to non-woff* fonts in tinymce.css
# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/requirejs-config.js
#	app/code/Magento/PageBuilder/view/frontend/web/js/default.js
# Conflicts:
#	app/code/Magento/PageBuilder/view/adminhtml/requirejs-config.js
#	app/code/Magento/PageBuilder/view/frontend/web/js/default.js
@irenelagno
Copy link
Contributor Author

SVC http://10.234.202.68:8080/job/Semantic-Version-Checker-Tests/339/artifact/svc-magento2-page-builder.log
minor change: adding new file to render widgets
patch change: update data migration script to support new master format

@irenelagno
Copy link
Contributor Author

MTF failure isn't related to our changes and because of known failure of MTF / Functional-Tests-EE / Functional Tests EE - MTF / Magento_Checkout_Test_TestCase_OnePageCheckoutOfflinePaymentMethodsTest

@irenelagno irenelagno merged commit 055adf3 into magento:develop Jun 20, 2018
@irenelagno irenelagno deleted the MAGETWO-87081-video branch June 21, 2018 16:29
magento-cicd2 pushed a commit that referenced this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants