-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ENGCOM-7563: #26682 Disallow setting extension attributes as data array
#27338 - Merge Pull Request #27338 from iMi-digital/magento2:fix/26682-no-overwriting-extension-attributes - Merged commits: 1. ea70c0b 2. dcb59d3 3. bc18a8f 4. 013bbc9 5. 7d86388 6. 517bc6e 7. c29e323 8. b60504e 9. 65c7153 10. 0753860 11. f133bff 12. c38d998 13. 579712b 14. 0518666 15. 2aae8ae
- Loading branch information
Showing
1 changed file
with
121 additions
and
0 deletions.
There are no files selected for viewing
121 changes: 121 additions & 0 deletions
121
...tional/testsuite/Magento/Quote/Api/GuestShipmentEstimationWithExtensionAttributesTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,121 @@ | ||
<?php | ||
/** | ||
* Copyright © Magento, Inc. All rights reserved. | ||
* See COPYING.txt for license details. | ||
*/ | ||
namespace Magento\Quote\Api; | ||
|
||
use Magento\Framework\Api\ExtensibleDataInterface; | ||
use Magento\TestFramework\ObjectManager; | ||
use Magento\TestFramework\TestCase\WebapiAbstract; | ||
use Magento\Quote\Api\Data\AddressInterface; | ||
|
||
class GuestShipmentEstimationWithExtensionAttributesTest extends WebapiAbstract | ||
{ | ||
const SERVICE_VERSION = 'V1'; | ||
const SERVICE_NAME = 'quoteGuestShipmentEstimationV1'; | ||
const RESOURCE_PATH = '/V1/guest-carts/'; | ||
|
||
/** | ||
* @var ObjectManager | ||
*/ | ||
private $objectManager; | ||
|
||
protected function setUp(): void | ||
{ | ||
$this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager(); | ||
} | ||
|
||
/** | ||
* @magentoAppIsolation enabled | ||
* @magentoDbIsolation disabled | ||
* @magentoApiDataFixture Magento/SalesRule/_files/cart_rule_free_shipping.php | ||
* @magentoApiDataFixture Magento/Sales/_files/quote.php | ||
*/ | ||
public function testEstimateByExtendedAddress(): void | ||
{ | ||
/** @var \Magento\Quote\Model\Quote $quote */ | ||
$quote = $this->objectManager->create(\Magento\Quote\Model\Quote::class); | ||
$quote->load('test01', 'reserved_order_id'); | ||
$cartId = $quote->getId(); | ||
if (!$cartId) { | ||
$this->fail('quote fixture failed'); | ||
} | ||
|
||
/** @var \Magento\Quote\Model\QuoteIdMask $quoteIdMask */ | ||
$quoteIdMask = \Magento\TestFramework\Helper\Bootstrap::getObjectManager() | ||
->create(\Magento\Quote\Model\QuoteIdMaskFactory::class) | ||
->create(); | ||
$quoteIdMask->load($cartId, 'quote_id'); | ||
//Use masked cart Id | ||
$cartId = $quoteIdMask->getMaskedId(); | ||
$serviceInfo = [ | ||
'rest' => [ | ||
'resourcePath' => '/V1/guest-carts/' . $cartId . '/estimate-shipping-methods', | ||
'httpMethod' => \Magento\Framework\Webapi\Rest\Request::HTTP_METHOD_POST, | ||
], | ||
'soap' => [ | ||
'service' => self::SERVICE_NAME, | ||
'serviceVersion' => 'V1', | ||
'operation' => self::SERVICE_NAME . 'EstimateByExtendedAddress', | ||
], | ||
]; | ||
if (TESTS_WEB_API_ADAPTER == self::ADAPTER_SOAP) { | ||
/** @var \Magento\Quote\Model\Quote\Address $address */ | ||
$address = $quote->getShippingAddress(); | ||
|
||
$data = [ | ||
AddressInterface::KEY_ID => (int)$address->getId(), | ||
AddressInterface::KEY_REGION => $address->getRegion(), | ||
AddressInterface::KEY_REGION_ID => $address->getRegionId(), | ||
AddressInterface::KEY_REGION_CODE => $address->getRegionCode(), | ||
AddressInterface::KEY_COUNTRY_ID => $address->getCountryId(), | ||
AddressInterface::KEY_STREET => $address->getStreet(), | ||
AddressInterface::KEY_COMPANY => $address->getCompany(), | ||
AddressInterface::KEY_TELEPHONE => $address->getTelephone(), | ||
AddressInterface::KEY_POSTCODE => $address->getPostcode(), | ||
AddressInterface::KEY_CITY => $address->getCity(), | ||
AddressInterface::KEY_FIRSTNAME => $address->getFirstname(), | ||
AddressInterface::KEY_LASTNAME => $address->getLastname(), | ||
AddressInterface::KEY_CUSTOMER_ID => $address->getCustomerId(), | ||
AddressInterface::KEY_EMAIL => $address->getEmail(), | ||
AddressInterface::SAME_AS_BILLING => $address->getSameAsBilling(), | ||
AddressInterface::CUSTOMER_ADDRESS_ID => $address->getCustomerAddressId(), | ||
AddressInterface::SAVE_IN_ADDRESS_BOOK => $address->getSaveInAddressBook(), | ||
ExtensibleDataInterface::EXTENSION_ATTRIBUTES_KEY => [ | ||
'discounts' => [] | ||
] | ||
]; | ||
|
||
$requestData = [ | ||
'cartId' => $cartId, | ||
'address' => $data | ||
]; | ||
} else { | ||
|
||
$requestData = [ | ||
'address' => [ | ||
'country_id' => "US", | ||
'postcode' => null, | ||
'region' => null, | ||
'region_id' => null, | ||
'extension_attributes' => [ | ||
'discounts' => [] | ||
] | ||
] | ||
]; | ||
} | ||
|
||
// Cart must be anonymous (see fixture) | ||
$this->assertEmpty($quote->getCustomerId()); | ||
|
||
$result = $this->_webApiCall($serviceInfo, $requestData); | ||
|
||
$this->assertNotEmpty($result); | ||
$this->assertEquals(1, count($result)); | ||
foreach ($result as $rate) { | ||
$this->assertEquals("flatrate", $rate['carrier_code']); | ||
$this->assertEquals(0, $rate['amount']); | ||
} | ||
} | ||
} |