[WebApi test] Disallow setting extension attributes as data array

[amenk]

Fixes #26682
While working on fix for the issue #26682 - fix already was delivered in fcd1b58#diff-e2b9d1a5f4b9f3503a2f8dd072bc2d8aR360, but it contains only unit tests, while this PR contained also web api tests, that better fits for such cases.

We decided to revert all changes related to the fix and deliver only tests as part of this PR.

[m2-assistant]

Hi @amenk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[lenaorobei]

@amenk I assume we can close this PR?

[amenk]

I have to closer check the results. Actually it seems to be a valid solution to the problem in the linked issue.

[maximbaibakov]

Looks like valid solution.
Can we get this merged into 2.3.x as well?

[amenk]

I have no clue why functional tests fail for B2B and EE -> rerunning

[amenk]

Functional tests EE is green now without any change.
Functional Tests B2B is still red, but https://public-results-storage-prod.magento-testing-service.engineering/reports/magento/magento2/pull/27338/73c167e6c2bcafd4451bd73a67d6ab3f/Functional/allure-report-b2b/index.html# does not indicate any errors, so I am rerunning Functional B2B once again.

[ihor-sviziev]

Hi @amenk ,
Your changes looks good to me. Could you cover them with any type of tests in order to prevent appearing this issue in future?
I think API test there is the most suitable.

Note: failing functional tests seems to me as false positive, no need to fix them

[amenk]

@ihor-sviziev
Thanks for your feedback.

I might not have the time in the near future to cover this with tests, I am happy if someone can take over.

[engcom-Kilo]

@ihor-sviziev
Exist api-functional test
dev/tests/api-functional/testsuite/Magento/Quote/Api/GuestShipmentEstimationTest.php::testEstimateByExtendedAddress

can be related to this Pull Request

[ihor-sviziev]

@engcom-Kilo good test example! Thank you.
@amenk maybe you could copy just duplicate that test case and a bit adjust it? I think it shouldn’t be really hard

[amenk]

@engcom-Kilo thank you
@ihor-sviziev woudn't that mean I have to do the full extension attribute setup during the test?

[ihor-sviziev]

@amenk as I understood - issue appears when you have extension attribute in the request, not in the model they you loaded. In this case it seems to me that declaring attribute is not mandatory. Let me know if I’m wrong

[amenk]

unfortunately not,

            $data = [
                AddressInterface::KEY_ID => (int)$address->getId(),
                AddressInterface::KEY_REGION => $address->getRegion(),
                AddressInterface::KEY_REGION_ID => $address->getRegionId(),
                AddressInterface::KEY_REGION_CODE => $address->getRegionCode(),
                AddressInterface::KEY_COUNTRY_ID => $address->getCountryId(),
                AddressInterface::KEY_STREET => $address->getStreet(),
                AddressInterface::KEY_COMPANY => $address->getCompany(),
                AddressInterface::KEY_TELEPHONE => $address->getTelephone(),
                AddressInterface::KEY_POSTCODE => $address->getPostcode(),
                AddressInterface::KEY_CITY => $address->getCity(),
                AddressInterface::KEY_FIRSTNAME => $address->getFirstname(),
                AddressInterface::KEY_LASTNAME => $address->getLastname(),
                AddressInterface::KEY_CUSTOMER_ID => $address->getCustomerId(),
                AddressInterface::KEY_EMAIL => $address->getEmail(),
                AddressInterface::SAME_AS_BILLING => $address->getSameAsBilling(),
                AddressInterface::CUSTOMER_ADDRESS_ID => $address->getCustomerAddressId(),
                AddressInterface::SAVE_IN_ADDRESS_BOOK => $address->getSaveInAddressBook(),

                'custom_attributes' => [
                    [
                    'attribute_code' =>  'company2',
                    'value' => 'ACME Division',
                    ],
                    [
                    'attribute_code' =>  'company3',
                    'value' => 'ACME Subdivision',
                    ]
                ]
            ];

Test does not fail, even my fix is not in place

[amenk]

Also we better would make the test for a registered user...

[engcom-Kilo]

@magento run all tests

[ihor-sviziev]

@engcom-Kilo how come earlier these files were needed and now - no?

[engcom-Kilo]

@engcom-Kilo how come earlier these files were needed and now - no?

Checked again,
and see that these files not working for test.

These sample files only for app/code/ .
Unused files.

[ihor-sviziev]

✔ Approved.

Failing tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7563 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[m2-assistant]

Hi @amenk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.