Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Online/Offline Status with each Credit Memo #1106

Closed
jason-neumann opened this issue Mar 18, 2015 · 5 comments
Closed

Store Online/Offline Status with each Credit Memo #1106

jason-neumann opened this issue Mar 18, 2015 · 5 comments
Assignees
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@jason-neumann
Copy link

Currently credit memos don't store if their transaction was done online or offline. This can make it hard to tell what's happened to an order if there are multiple credit memo's applied to it. I suggest adding a column to sales_flat_creditmemo called online_refund that's a tinyint and is set to 1 if the refund is done online. This could then be added to the Credit Memo's main grid and when viewing an order and would enable quick filtering to see just the online or offline refunds.

This has great benefits from the merchant standpoint because you can then easily reconcile refunds made through Paypal (or whoever your gateway is) and refunds made by cash or whatever other method.

I would be willing to submit a pull request for the feature if it's something Magento is interested in.

@asemenenko
Copy link

Hi Jason,

I have an additional question to you regarding usage of Sales -> Transactions grid that allows to filter online transactions. Basically you need to add some of the capabilities of that grid to the credit memo's grid. What if that Transactions grid will show an offline and online documents? Will it solve your problem?

/regards
Andrii

@asemenenko
Copy link

@jason-neumann is there an update for my question from your side?

@jason-neumann
Copy link
Author

Sorry I lost track of this.
I don't think modifying Sales -> Transactions grid would help here. Or at least it would be more work than my original suggestion. The transactions grid does not contain any information about offline credit memos, and it shouldn't, in my opinion. Offline credit memos are ones that occur outside of the magento system and likely weren't processed through paypal. As far as I understand it, an offline credit memo is just to track external credits. So we would have to first add code to create transactions for offline credit memos.

If that was added then we'd still have to look at the fact that the transaction's grid doesn't display any information on the amount of the transaction (kind of odd to me, but it's in 1,000 other places so I've never really cared about it). So there is the extra work involved to add that to the grid along with if it was an online or offline transaction.

So all in all I think it would be better to add the data to credit memos and their grid. But in the end it's your call.

@asemenenko
Copy link

Improvement is now described and captured in MAGETWO-991

/regards

@vpelipenko vpelipenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 17, 2015
@vkorotun vkorotun removed the CS label Aug 4, 2016
@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

magento-team pushed a commit that referenced this issue May 16, 2017
VitaliyBoyko pushed a commit to VitaliyBoyko/magento2 that referenced this issue Jun 22, 2018
Zero compensational reservations after invoice creation for order with virtual or downloadable products
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants