Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete custom option file in admin order create #24842

Closed
adrian-martinez-interactiv4 opened this issue Oct 3, 2019 · 8 comments
Closed
Assignees
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@adrian-martinez-interactiv4
Copy link
Contributor

Unable to delete custom option file in admin order create due to js error. See steps to reproduce and actual and expected results for further information.

Preconditions (*)

  1. Magento 2.3.2
  2. PHP 7.2

Steps to reproduce (*)

  1. Have a product with at least one custom option of type file as follows:

Captura de pantalla 2019-10-03 a las 15 26 08

  1. Go to Sales -> Orders, click Create New Order button
  2. Select or create a customer, and proceed to order creation.
  3. Select customizable product to be added to quote.
  4. Configure it with a file, in this case is an image called test.png:

Captura de pantalla 2019-10-03 a las 15 27 09

  1. Click Ok, image gets uploaded and attached to custom option successfully.
  2. Click on Configure button in item row again, in order to try to delete the just uploaded file:

Captura de pantalla 2019-10-03 a las 15 36 49

  1. In configure sidebar, click on Delete checkbox, next to the file input.

Expected result (*)

  1. File name gets strikethrough, no js errors:

Captura de pantalla 2019-10-03 a las 15 28 43

  1. When Ok clicked, and reopened through Configure button, I expect no file to be there:

Captura de pantalla 2019-10-03 a las 15 41 57

Actual result (*)

  1. Js error due to bad selector, that avoids to prepare fields for submit, so file does not get removed:

Captura de pantalla 2019-10-03 a las 15 27 48

@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @adrian-martinez-interactiv4. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@adrian-martinez-interactiv4 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 3, 2019
@engcom-Bravo engcom-Bravo self-assigned this Oct 3, 2019
@m2-assistant
Copy link

m2-assistant bot commented Oct 3, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@adrian-martinez-interactiv4
Copy link
Contributor Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @adrian-martinez-interactiv4. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @adrian-martinez-interactiv4, here is your Magento instance.
Admin access: https://i-24842-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@adrian-martinez-interactiv4
Copy link
Contributor Author

@adrian-martinez-interactiv4 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

Captura de pantalla 2019-10-03 a las 15 52 02

adrian-martinez-interactiv4 added a commit to adrian-martinez-interactiv4/magento2 that referenced this issue Oct 3, 2019
…er create

Fix inputBox selector to match html structure
@engcom-Bravo engcom-Bravo added Component: Catalog Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 4, 2019
@ghost ghost unassigned engcom-Bravo Oct 4, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-21498 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@milindsingh milindsingh added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Oct 9, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Feb 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @adrian-martinez-interactiv4. Thank you for your report.
The issue has been fixed in #24843 by @adrian-martinez-interactiv4 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

magento-engcom-team added a commit that referenced this issue Feb 13, 2020
…in order create #24843

 - Merge Pull Request #24843 from adrian-martinez-interactiv4/magento2:FR23#FEATURE-UNABLE-DELETE-CUSTOM-OPTION-FILE
 - Merged commits:
   1. 504dd91
   2. 3eb4110
   3. 6e4a041
@github-jira-sync-bot github-jira-sync-bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Catalog Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

5 participants