Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL product search does not consider Category Permissions configuration #28563

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 12 comments · Fixed by #28757
Closed
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

GraphQL product search does not consider Category Permissions on category level and in System Configuration (Stores > Configuration > Catalog > Catalog > Category Permissions)

Preconditions
  1. Install 2.3-develop
  2. Create product Apple in category sub with price $10
  3. Go to Stores > Configuration > Catalog > Catalog > Category Permissions
  4. Set Enable to Yes and leave all other options as is (it means that all categories and products will be hidden for all customers or not logged in users)
  5. Save Config and clear cache
  6. Make sure that category sub is not accessible from the storefront as well as simple product Apple by direct URL
Steps
  1. Send GraphQL request:
query{
products(search: "Apple"){
	items {    
		name
		price {
			minimalPrice {
				amount {
					value
					currency
					}								
				}
			}  
		sku
	}
	total_count
	}
}

(-) The response contains data of product Apple

(+) Not enough permissions error message displayed

@magento-engcom-team magento-engcom-team added Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for Dev in Community Backlog Jun 5, 2020
@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 5, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @pmarjan. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jun 5, 2020
@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog Jun 9, 2020
@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 9, 2020
@ghost ghost removed the Progress: ready for dev label Jun 9, 2020
pmarjan added a commit that referenced this issue Jun 9, 2020
… configuration

Apply catalog permissions to product search query
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 9, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jun 18, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jun 18, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jun 19, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 19, 2020
@ghost ghost moved this from PR In Progress to Dev in Progress in Community Backlog Jun 20, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jun 21, 2020
@nrkapoor nrkapoor moved this from Dev in Progress to PR In Progress in Community Backlog Jun 21, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jun 23, 2020
@cpartica cpartica added the PAP Partners acceleration program label Jun 24, 2020
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jul 8, 2020
…issions configuration - Pass the context as argument

Reveert AddUsserInfoToContext
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jul 9, 2020
…issions configuration - Pass the context as argument

Pass context to configurable variant collection
pmarjan added a commit to pmarjan/magento2 that referenced this issue Jul 9, 2020
…issions configuration - Pass the context as argument

Address static tests
@ghost ghost moved this from PR In Progress to Dev in Progress in Community Backlog Jul 10, 2020
@ghost ghost moved this from Dev in Progress to Done (last 30 days) in Community Backlog Jul 10, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 15, 2020
AntonEvers added a commit to AntonEvers/magento2 that referenced this issue Jul 16, 2020
* upstream/2.4-develop: (592 commits)
  Write metadata to the GIF and PNG format
  Add metadata TO the test image
  Correct pagination behavior
  MQE-2220: fixed deprecated action group usage and annotation errors in MFTF tests
  add missing properties
  Fix namespaces
  remove protected property
  Cover changes with integration tests
  Fix static tests
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - fixed review comments
  Code review suggestions
  Introduce SearchAssets service
  magento#28569: Multi-store: Missing store codes in relation to a group and website
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - fixed review and static failures
  MQE-2220: updated mftf version to ^3.0  - removed deprecated action groups as they are removed from 2.4.0  - fixed test annotation errors
  MC-35776: WsdlGenerationFromDataObjectTest is failed with PHP 7.4.6
  MC-20637: MyAccount :: Order Details :: Invoice Details by Order Number - review fixes
  magento#28563: GraphQL product search does not consider Category Permissions configuration - Pass the context as argument
  magento#28569: Multi-store: Missing store codes in relation to a group and website
  MC-34649: Uses Per Coupon and Uses Per Customer not honored with concurrent orders
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
No open projects
Community Backlog
  
Done (last 30 days)
7 participants