Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Progress Steps #3076

Closed
teuma86 opened this issue Jan 22, 2016 · 1 comment
Closed

Translate Progress Steps #3076

teuma86 opened this issue Jan 22, 2016 · 1 comment

Comments

@teuma86
Copy link

teuma86 commented Jan 22, 2016

I have noticed the progress steps in the checkout dont seem to be translatable. Unless I am missing something.

The template file Magento_Checkout/view/frontend/web/template/progress-bar.html has the line
data-bind"text item.title, click: $parent.navigateTo"

This is not translatable, however, even if it was, it will not translate, as it will look for translation for the string "item.title" not the array value

Now item.title is defined in
Magento_Checkout/view/frontend/web/js/view/shipping.js
Magento_Checkout/view/frontend/web/js/view/payments.js

Both places this is just added to stepNavigator.registerStep as a string without passing through translations.

The best solution would be to pass it through translations in shipping.js / payments.js

Example shipping.js

var shippingText = $t('Shipping')
if (!quote.isVirtual()) {
stepNavigator.registerStep(
'shipping',
'',
shippingText,
this.visible, _.bind(this.navigate, this),
10
);
}

Please can this be fixed so these fields can be translated.

@teuma86
Copy link
Author

teuma86 commented Jan 22, 2016

Duplicate

@teuma86 teuma86 closed this as completed Jan 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant