[Issue] [PHPMD] Add phpmd rule with ignoring of unused required parameters in the plugins #37914
Labels
Area: Framework
Component: Catalog
Issue: Confirmed
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Priority: P3
May be fixed according to the position in the backlog.
Reproduced on 2.4.x
The issue has been reproduced on latest 2.4-develop branch
Severity: S4
Affects aesthetics, professional look and feel, “quality” or “usability”.
This issue is automatically created based on existing pull request: #33918: [PHPMD] Add phpmd rule with ignoring of unused required parameters in the plugins
Description (*)
This PR improve phpmd
UnusedFormalParameter
rule with ignoring of required unused parameters in the plugins.around
andafter
plugins has 2 required params$subject
and$proceed
(or$result
forafter
plugin).before
plugin has 1 required param$subject
.This PR override standard
UnusedFormalParameter
rule and allow don't use@SuppressWarnings(PHPMD.UnusedFormalParameter)
in the plugins.Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
@SuppressWarnings(PHPMD.UnusedFormalParameter)
from some pluginPluginInterface
implementation into the classUnusedFormalParameter
errorsQuestions or comments
Contribution checklist (*)
The text was updated successfully, but these errors were encountered: