-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Component: ThemeFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release
Description
Preconditions
- Magento 2.2.4
- PHP 7.1.17
- Redis 3.2.11
- Mysql Ver 14.14 Distrib 5.6.39-83.1
Steps to reproduce
- Create a parent theme ex:
parent
(extending or not the blank theme) - Create a child theme of
parent
for the desktop version ex:desktop
- Create another child theme of
parent
for mobile devices ex:mobile
- In all themes, create the
Magento_Theme/templates/html/footer.phtml
file with different content. - In the Admin section
Content -> Design -> Configuration
edit the Global Scope and set thedesktop
theme as default. Click Add New User Agent Rule button and add an exception for/(iPhone|iPod|iPad|Android)/i
to use themobile
theme. - In a browser visit the site with "Responsive Design Mode" enabled and change the user agent to one one of the above. Note that the categories pages, listings and CMS pages are working fine.
- Visit a product page. Note that the
desktop
footer is loading regardless of the user agent.
Expected result
What I find strange is that some templates are loading fine. For instance the header.phtml header will load proper one form the mobile
theme based on the user agent but not the footer.phtml
or the absolute_footer.phtml
.
Actual result
- The
footer.phtml
andabsolute_footer.phtml
templates are loading from thedesktop
theme instead of themobile
theme regardless of the user agent.
###Notes
For me, this has broken after upgrading to 2.2.4, on 2.1.10 it was working fine and it was loading the proper templates based on the user agent.
danemacmillan, neutronixx, gpcrocker and AlekosDordas
Metadata
Metadata
Assignees
Labels
Component: ThemeFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for developmentGate 4. Acknowledged. Issue is added to backlog and ready for developmentReproduced on 2.2.xThe issue has been reproduced on latest 2.2 releaseThe issue has been reproduced on latest 2.2 releaseReproduced on 2.3.xThe issue has been reproduced on latest 2.3 releaseThe issue has been reproduced on latest 2.3 release