Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Remove not-allowed currencies from the currencies dropdown in Setup #13782

Merged
merged 3 commits into from
Mar 9, 2018
Merged

[Forwardport] Remove not-allowed currencies from the currencies dropdown in Setup #13782

merged 3 commits into from
Mar 9, 2018

Conversation

nmalevanec
Copy link
Contributor

@nmalevanec nmalevanec commented Feb 22, 2018 •
edited
Loading

Original Pull Requests

#13770
#13966

Description

As reported on #13760 some deprecated currencies were being displayed in the setup process.
This PR removes these and other not-allowed currencies from the setup step 4 (customize your store).

Fixed Issues (if relevant)

  1. Fixes Remove deprecated Brazilian currencies in the setup process #13760 by not displaying old and deprecated Brazilian currencies
  2. Remove not-allowed currencies for being displayed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ihor-sviziev ihor-sviziev self-assigned this Feb 22, 2018
@ihor-sviziev
Copy link
Contributor

Looks like there should be one more fix - change property visibility from protected to private. But let's wait answer to my question in original PR #13770 (comment)

@ihor-sviziev
Copy link
Contributor

Hi @nmalevanec could you also add changes from my PR? #13966

@nmalevanec
Copy link
Contributor Author

@ihor-sviziev , done.

@ihor-sviziev @nmalevanec
Setup Lists - Make allowedCurrencies property private
ef94d44 
This property was introduced in b1a5bc1 with protected visibility
@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 6, 2018
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-748 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Mar 9, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit ef94d44 into magento:2.3-develop Mar 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 9, 2018
ENGCOM-748: [Forwardport] Remove not-allowed currencies from the curr…
6a48ee1 
…encies dropdown in Setup #13782
@nmalevanec nmalevanec deleted the 2.3-develop-PR-port-13770 branch August 21, 2018 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@nmalevanec @ihor-sviziev @magento-engcom-team @sidolov @r-martins