Skip to content

Conversation

r-martins
Copy link
Contributor

@r-martins r-martins commented Feb 21, 2018

Description

As reported on #13760 some deprecated currencies were being displayed in the setup process.
This PR removes these and other not-allowed currencies from the setup step 4 (customize your store).

Fixed Issues (if relevant)

  1. Fixes Remove deprecated Brazilian currencies in the setup process #13760 by not displaying old and deprecated Brazilian currencies
  2. Remove not-allowed currencies for being displayed

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Feb 21, 2018

CLA assistant check
All committers have signed the CLA.

@r-martins r-martins changed the title Remove non-allowed currencies from the currencies dropdown in Setup Remove not-allowed currencies from the currencies dropdown in Setup Feb 21, 2018
@r-martins
Copy link
Contributor Author

#MLAU18

@okorshenko
Copy link
Contributor

Hi @r-martins could you please sign CLA (Contributor License Agreement)?

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
MAGETWO-88155 has been created to process this Pull Request

@r-martins
Copy link
Contributor Author

Hi @okorshenko ,
I just signed the CLA and added the used e-mail to my account. ;)

@ihor-sviziev
Copy link
Contributor

@r-martins @okobchenko is there any reason why new property was added with protected visibility instead of private?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants