Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Format the javascript code in Tax module #15560

Merged
merged 4 commits into from
May 30, 2018
Merged

[Forwardport] Format the javascript code in Tax module #15560

merged 4 commits into from
May 30, 2018
+21 −6

Conversation

gelanivishal
Copy link
Contributor

Original Pull Request

#15343

Description

Refactor javascript validate code in Tax module.

Fixed Issues (if relevant)

  1. Reformat the javascript code as per magento standards. #15352: Reformat the javascript code as per magento standards

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@osrecio osrecio self-assigned this May 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone May 29, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request May 30, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 60ed680 into magento:2.3-develop May 30, 2018
magento-engcom-team pushed a commit that referenced this pull request May 30, 2018
ENGCOM-1698: [Forwardport] Format the javascript code in Tax module #…
779ddd8 
…15560
@magento-engcom-team
Copy link
Contributor

Hi @vgelani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidalger davidalger Awaiting requested review from davidalger

Assignees

@osrecio osrecio

Labels
Area: Frontend Component: Tax Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@gelanivishal @magento-engcom-team @osrecio @VladimirZaets