-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Event: dmcdindiaFixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passed
Description
- Magento 2.2.4
- PHP 7.1.15
- MySQL 14.14
- Ubuntu
Use javascript inside *.phtml file it's legacy code that we try to refactor according to Magento way.
For that we have <script type="text/x-magento-init" /> tag, where we declare path to JS file and pass parameters if they are needed.
Preconditions
N/A
Steps to reproduce
N/A
Expected result
JS Script code should be removed from template file and treated as a separate component
Actual result
Affected file: app/code/Magento/Tax/view/adminhtml/templates/class/page/edit.phtml
JS script is added directly to template file.(Wrong coding format)
Metadata
Metadata
Assignees
Labels
Event: dmcdindiaFixed in 2.1.xThe issue has been fixed in 2.1 release lineThe issue has been fixed in 2.1 release lineFixed in 2.2.xThe issue has been fixed in 2.2 release lineThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineThe issue has been fixed in 2.3 release lineIssue: Format is validGate 1 Passed. Automatic verification of issue format passedGate 1 Passed. Automatic verification of issue format passed