Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout shipping tooltip 20838 #20839

Conversation

abrarpathan19
Copy link
Contributor

@abrarpathan19 abrarpathan19 commented Jan 31, 2019

Description (*)

Luma theme shipping tool tip icon cut from leftside

Fixed Issues (if relevant)

  1. Luma theme shipping tool tip icon cut from leftside #20838: Luma theme shipping tool tip icon cut from leftside

Manual testing scenarios (*)

1 Go to checkout- shipping page
2 Find the field shippingAddress telephone tool tip icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Jan 31, 2019

@magento-engcom-team give me test instance

@slavvka slavvka self-assigned this Jan 31, 2019
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-4262 has been created to process this Pull Request

@sivaschenko sivaschenko changed the base branch from 2.3-develop to 2.2-develop February 15, 2019 12:18
@sivaschenko sivaschenko changed the base branch from 2.2-develop to 2.3-develop February 15, 2019 12:18
@ghost
Copy link

ghost commented Feb 18, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants