Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Checkout shipping tooltip 20838 #21324

Conversation

abrarpathan19
Copy link
Contributor

Original Pull Request

#20839

Description (*)

Luma theme shipping tool tip icon cut from leftside

Fixed Issues (if relevant)

  1. Luma theme shipping tool tip icon cut from leftside #20838: Luma theme shipping tool tip icon cut from leftside

Manual testing scenarios (*)

1 Go to checkout- shipping page
2 Find the field shippingAddress telephone tool tip icon

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @abrarpathan19. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4329 has been created to process this Pull Request

@dmytro-ch
Copy link
Contributor

Hi @abrarpathan19, according to the latest changes in contribution guide, the minor style/design fixes are considered as Code Cleanup. Magento Code Contributions Guide - Base achievements
Unfortunately, we can't accept this Pull Request to 2.2 release line, all code cleanup should be delivered to 2.3 release line. For more information, please, refer to Magento Code Contributions Guide.
Thank you!

@dmytro-ch dmytro-ch closed this Feb 20, 2019
@ghost
Copy link

ghost commented Feb 20, 2019

Hi @abrarpathan19, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants