Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24353 Fix Varnish 6 Too many restarts issue #28137

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented May 7, 2020

Description (*)

This PR applies fix from #24353 (comment), it was confirmed that it fixes issue in #24353 (comment).

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento varnish 6 Too many restarts #24353

Manual testing scenarios (*)

  1. See Magento varnish 6 Too many restarts #24353

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 7, 2020

Hi @ihor-sviziev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev ihor-sviziev linked an issue May 7, 2020 that may be closed by this pull request
@sdzhepa sdzhepa added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label May 7, 2020
@Hanhan1989
Copy link

The functional Tests B2B failed!

@ihor-sviziev
Copy link
Contributor Author

The functional Tests B2B failed!

Looks like false positive

@Hanhan1989
Copy link

The functional Tests B2B failed!

Looks like false positive

I think so. The error was the following:

SUITE PRECONDITION FAILED:
Can't connect to Webdriver at http://localhost:5555/wd/hub. Please make sure that Selenium Server or PhantomJS is running.

kierenevans added a commit to inviqa/harness-base-php that referenced this pull request Jun 5, 2020
kierenevans added a commit to inviqa/harness-base-php that referenced this pull request Jun 11, 2020
kierenevans added a commit to inviqa/harness-base-php that referenced this pull request Jun 18, 2020
kierenevans added a commit to inviqa/harness-base-php that referenced this pull request Jun 18, 2020
@ihor-sviziev
Copy link
Contributor Author

@lbajsarowicz maybe you could review my PR?

Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ According to the documentation, this change is fine.

I'd love to see review from someone who has more expertise with Varnish,.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7761 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

Magento 2.4-develop;
Sample Data;
Php 7.3;
Varnish v. 6.2

Manual testing scenario:

  1. Configure Varnish and Web server (Apache 2 in my case) devdocs;
  2. Configure Magento to use Varnish

Go to Admin->Stores->Configuration->System->Full Page Cache:

  • set Cache Application to Varnish Cache;
  • set TTL for public content to 120 sec;
    Screenshot from 2020-04-28 11-52-06
  1. Export Varnish 6 VCL, configure and restart varnish service;
  2. Run varnishlog in console;
  3. Go to Storefront and try browsing the site for longer than 10min.

Before: ✖️ VCL keeps restarting forever resulting in: - VCL_Error Too many restarts after a few tries
503 Response status and VCL error: Too many restarts

Peek 2020-07-09 16-19

2020-07-09_16-28

After: ✔️ No 503 errors caused by restart. Everything works as expected

@engcom-Kilo engcom-Kilo self-assigned this Jul 9, 2020
@engcom-Kilo engcom-Kilo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 9, 2020
@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 4, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 5, 2020
@magento-engcom-team magento-engcom-team merged commit b268ebb into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @ihor-sviziev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@jonashrem jonashrem mentioned this pull request Sep 27, 2021
4 tasks
ihor-sviziev added a commit that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: PageCache Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Magento varnish 6 Too many restarts
7 participants