-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#24353 Fix Varnish 6 Too many restarts issue #28137
#24353 Fix Varnish 6 Too many restarts issue #28137
Conversation
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
The functional Tests B2B failed! |
Looks like false positive |
I think so. The error was the following:
|
@lbajsarowicz maybe you could review my PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ According to the documentation, this change is fine.
I'd love to see review from someone who has more expertise with Varnish,.
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA Passed Preconditions: Magento 2.4-develop; Manual testing scenario:
Go to Admin->Stores->Configuration->System->Full Page Cache:
Before: ✖️ VCL keeps restarting forever resulting in: - VCL_Error Too many restarts after a few tries After: ✔️ No 503 errors caused by restart. Everything works as expected |
Hi @ihor-sviziev, thank you for your contribution! |
Description (*)
This PR applies fix from #24353 (comment), it was confirmed that it fixes issue in #24353 (comment).
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)