Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport #28137 to 2.3 #34170

Merged
merged 2 commits into from
Oct 7, 2021
Merged

backport #28137 to 2.3 #34170

merged 2 commits into from
Oct 7, 2021

Conversation

jonashrem
Copy link
Contributor

@jonashrem jonashrem commented Sep 27, 2021 •
edited by ihor-sviziev
Loading

backports #24353 to Magento 2.3

Description (*)

this backports the fix #28137 for #24353 to Magento 2.3 as the issue can happen there as well

Related Pull Requests

https://github.com/magento-commerce/magento2-infrastructure/pull/1612

Fixed Issues (if relevant)

  1. Magento varnish 6 Too many restarts #24353

Release Notes

Fixes issue with Varnish 6 when 503 error was returned and VCL error Too many restarts in logs

Categories

Payments

Manual testing scenarios (*)

/

Questions or comments

/

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • x ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@jonashrem
backport magento#24353 to 2.3
0d6154d 
backports magento#24353  to Magento 2.3
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2021

Hi @jonashrem. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3 instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ihor-sviziev ihor-sviziev changed the base branch from 2.3 to 2.3.7-release September 29, 2021 18:57
ihor-sviziev
ihor-sviziev previously approved these changes Sep 29, 2021
View reviewed changes
@m2-github-services m2-github-services changed the base branch from 2.3.7-release to 2.3.7-patch-34170 September 29, 2021 18:58
@m2-github-services m2-github-services dismissed ihor-sviziev’s stale review September 29, 2021 18:58

The base branch was changed.

@m2-github-services
Copy link
Collaborator

@ihor-sviziev thank you for the review! We have changed pull request base branch in order to provide ability to merge current pull request and schedule quality patch delivery job.

ihor-sviziev
ihor-sviziev previously approved these changes Sep 30, 2021
View reviewed changes
@m2-github-services
Copy link
Collaborator

@ihor-sviziev thank you for the review! We have changed pull request base branch in order to provide ability to merge current pull request and schedule quality patch delivery job.

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

1 similar comment
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 30, 2021
@andrewbess andrewbess self-assigned this Sep 30, 2021
andrewbess
andrewbess previously approved these changes Sep 30, 2021
View reviewed changes
@m2-github-services
Copy link
Collaborator

@andrewbess thank you for the review! We have changed pull request base branch in order to provide ability to merge current pull request and schedule quality patch delivery job.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@ihor-sviziev
Copy link
Contributor

@sidolov, could you help with failing static tests? They look not related to changes from this PR

@sidolov
Copy link
Contributor

sidolov commented Oct 5, 2021

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Oct 5, 2021

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sidolov
Copy link
Contributor

sidolov commented Oct 6, 2021

@magento run Static Tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

sidolov
sidolov previously approved these changes Oct 6, 2021
View reviewed changes
@m2-github-services m2-github-services changed the base branch from 2.3.7-release to 2.3.7-patch-34170 October 6, 2021 17:16
@m2-github-services m2-github-services dismissed stale reviews from sidolov, andrewbess, and ihor-sviziev October 6, 2021 17:16

The base branch was changed.

@m2-github-services
Copy link
Collaborator

@sidolov thank you for the review! We have changed pull request base branch in order to provide ability to merge current pull request and schedule quality patch delivery job.

@m2-github-services
Copy link
Collaborator

@sidolov thank you for the review! We have changed pull request base branch in order to provide ability to merge current pull request and schedule quality patch delivery job.

@ihor-sviziev ihor-sviziev merged commit 492033c into magento:2.3.7-patch-34170 Oct 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2021

Hi @jonashrem, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-github-services
Copy link
Collaborator

@ihor-sviziev quality patch delivery job is successfully scheduled! Link to the quality patch tool pull request will be provided as soon as it's created

m2-github-services pushed a commit to magento/quality-patches that referenced this pull request Oct 7, 2021
Automatically generated patch for magento/magento2#34170
b035a60
@m2-github-services m2-github-services mentioned this pull request Oct 7, 2021
Merged
@m2-github-services
Copy link
Collaborator

Pull request with quality patch was successfully created, available by the link: magento/quality-patches#62

@engcom-Alfa
Copy link
Contributor

As it already merged, Moving it to recently Merged column!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@andrewbess andrewbess andrewbess left review comments

Assignees

@ihor-sviziev ihor-sviziev

@andrewbess andrewbess

@sidolov sidolov

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonashrem @m2-github-services @ihor-sviziev @sidolov @engcom-Alfa @andrewbess