Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base price storage website price mode #30126

Closed
wants to merge 35 commits into from
Closed

Base price storage website price mode #30126

wants to merge 35 commits into from

Conversation

wassuupp
Copy link

@wassuupp wassuupp commented Sep 21, 2020 •
edited by m2-assistant bot

Fix V1/products/base-prices endpoint to update prices for Catalog Price Mode - Website

Description (*)

V1/products/base-prices endpoint does not work with Catalog Price Mode - Website
Function was added to affect prices for all store views inside changed website

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Base price storage website price mode #30132: Base price storage website price mode

bubasuma and others added 3 commits September 17, 2020 09:03
@bubasuma
MC-34522: Two near-simultaneous product imports interfere with each o…
4c8d30a 
…ther

- Add user id to "import data" table in order to allow concurrent import
@atihanov
Base Price Storage model fix. V1/products/base-prices
18e880d 
 endpoint does not work with Product Price Mode - Website Function was added
 to affect prices for all store views inside changed website
@atihanov
Merge remote-tracking branch 'upstream/2.4-develop' into 2.4-develop
8f9faf1
@m2-assistant
Copy link

m2-assistant bot commented Sep 21, 2020

Hi @wassuupp. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ghost ghost added this to Pending Review in Pull Requests Dashboard Sep 21, 2020
@wassuupp wassuupp changed the title Base price storage website price mode1 Base price storage website price mode Sep 21, 2020
@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Risk: medium labels Sep 21, 2020
@sidolov
Copy link
Contributor

sidolov commented Sep 21, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Sep 21, 2020
Closed
4 tasks
@BarnyShergold
Copy link

@magento run all tests

@BarnyShergold BarnyShergold self-assigned this Sep 22, 2020
BarnyShergold
BarnyShergold requested changes Sep 22, 2020
View reviewed changes
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests need to be addressed and fixed

app/code/Magento/Catalog/Model/Product/Price/BasePriceStorage.php Outdated Show resolved Hide resolved
@ghost ghost moved this from Pending Review to Changes Requested in Pull Requests Dashboard Sep 22, 2020
@wassuupp
Copy link
Author

@magento run all tests

@engcom-Charlie engcom-Charlie self-assigned this Oct 5, 2020
@engcom-Charlie
Copy link
Contributor

@wassuupp could you please fix failed Static and Unit tests?
Thank you.

@engcom-Charlie
Copy link
Contributor

@wassuupp please fix failed Static and Unit tests? Otherwise, we can't proceed with your PR.
Thank you.

@sidolov
Copy link
Contributor

sidolov commented Oct 7, 2020

@wassuupp I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Oct 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2020

Hi @wassuupp, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ghost ghost removed this from Changes Requested in Pull Requests Dashboard Oct 7, 2020
@bubasuma
MC-34522: Two near-simultaneous product imports interfere with each o…
5f9668f 
…ther

- Change default value of user_id column to NULL for backward compatibility
@nuzil nuzil self-requested a review February 1, 2021 15:07
@wassuupp
Copy link
Author

wassuupp commented Feb 8, 2021

@magento run all tests

@BarnyShergold
Copy link

@magento run functional tests b2b

@BarnyShergold
Copy link

@magento run Functional Tests B2B

@BarnyShergold
Copy link

@wassuupp - The tests keep failing - please can you check these and see if there is any reason why you changes maybe affecting this

@wassuupp
Copy link
Author

@magento run all tests

@wassuupp wassuupp changed the base branch from 2.4-develop to 2.5-develop February 21, 2021 20:33
@wassuupp
Copy link
Author

@magento run Unit Tests

@wassuupp
Copy link
Author

@magento run all tests

@wassuupp wassuupp changed the base branch from 2.5-develop to 2.4-develop March 4, 2021 07:50
@wassuupp
Copy link
Author

wassuupp commented Mar 4, 2021

@magento run all tests

@nuzil
Copy link
Contributor

nuzil commented Mar 4, 2021

Closing as there are full mess in source branch. New one is coming

@nuzil nuzil closed this Mar 4, 2021
@m2-assistant
Copy link

m2-assistant bot commented Mar 4, 2021

Hi @wassuupp, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot removed this from Review in Progress in Pull Requests Dashboard Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BarnyShergold BarnyShergold BarnyShergold requested changes

@nuzil nuzil Awaiting requested review from nuzil

Assignees

@BarnyShergold BarnyShergold

@engcom-Charlie engcom-Charlie

Labels
Component: Catalog Priority: P3 May be fixed according to the position in the backlog. Release Line: 2.4 Risk: medium Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Base price storage website price mode