Category content upload media minify#31633

[gixid192]

Description (*)

The current regex syntax uses literal space (blank character) which leads to the elimination when applying minification process.

The fix simply changes blank character to \s, which is whitespace in regex rule/syntax.

Fixed Issues (if relevant)

Fixes #31633

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @gixid192. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gixid192]

@magento run all tests

[ihor-sviziev]

Hi @gixid192,
Could you cover your changes with any type of automated test?

[gixid192]

Hi @ihor-sviziev

I was wondering if I should write tests for this PR.
My code isn't new, blank to \s, the change is pretty much the same as before.

Do you think that it is necessary to write tests on this case?

[ihor-sviziev]

@gixid192 It's obvious that this code isn't new, but it was breaking in some cases. According to Magento Definition of Done - all code changes must be covered by automated tests (if possible). This is needed to make sure we'll not re-introduce it again in the future.

[gixid192]

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests, WebAPI Tests

[gixid192]

@magento run Functional Tests EE

[gixid192]

@ihor-sviziev The tests are all green now. So I assume the code is correct.

In case you still want a test for this PR, could you suggest a way? I mean, the error only happens when source is minified, how to test this, what kind of this test is this called? Also, as the whitespace and \s are all most the same, what should I write a test to differentiate those 2? I don't have much experience writing test so any help would be great.

[ihor-sviziev]

Hi @gixid192,
Yeah, I just analyzed your changes one more time, and it will be too hard to get it automatically tested somehow. I believe the only manual testing is possible here. I'm approving your PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8912 has been created to process this Pull Request

[engcom-Oscar]

✔️ QA passed

Was checked case from Manual testing scenarios

• Enable built-in JS Minification (production mode) ( bin/magento config:set dev/js/minify_files 1 )

• DIsable old media gallery ( Stores -> Configuration -> System -> Media Gallery and set Enable Old Media Gallery to No)

Steps to reproduce (*)

1. Go to Admin -> Catalog -> Categories -> Content -> Select from Gallery
2. Open the context menu for any image (3 dots) and select "Edit"
3. Enter image title, description, add keywords
4. Click "Save"

❌ Before:
Image details are not saved. Uncaught TypeError: Cannot read property 'call' of undefined in jquery.validate
There are JS console errors when media gallery is opened:
Uncaught SyntaxError: Invalid regular expression: missing / validate-image-title.min.js:1
Uncaught SyntaxError: Invalid regular expression: missing / validate-image-description.min.js:1

✔️ After:
Image details are saved without successfully.

[m2-assistant]

Hi @gixid192, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.