-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image details cannot be updated in new media gallery when JS Minificaiton is enabled #31633
Comments
Hi @thomas-kl1. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Alfa. Thank you for working on this issue.
|
✅ Confirmed by @engcom-Alfa Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
@magento give me 2.4-develop instance |
Hi @webkul-ajaysaini. Thank you for your request. I'm working on Magento instance for you. |
Hi @webkul-ajaysaini, here is your Magento Instance: https://3f92974422c1a650d8a077cda6701fb1-2-4-develop.instances.magento-community.engineering |
Updated description with the actual functional issue description. Increased priority to P2. |
Hi @thomas-kl1. Thank you for your report.
The fix will be available with the upcoming 2.4.3 release. |
can it be pulled via some patch |
@ia-gaurav You can check my pr here: https://github.com/magento/magento2/pull/32398/files |
Preconditions (*)
bin/magento config:set dev/js/minify_files 1
)Steps to reproduce (*)
Expected result (*)
Image details are saved
Actual result (*)
Image details are not saved.
Uncaught TypeError: Cannot read property 'call' of undefined
in jquery.validateThere are JS console errors when media gallery is opened:
Uncaught SyntaxError: Invalid regular expression: missing /
validate-image-title.min.js:1Uncaught SyntaxError: Invalid regular expression: missing /
validate-image-description.min.js:1Before/After Minification of the regex:
/^[a-zA-Z0-9\-\_\.\,\n\ ]+$|^$/i.test(value);
/^[a-zA-Z0-9\-\_\.\,\]+$/i.test(value);
Space and new line are escaped and not recognized as part of the regex. Also regarding the JSShrink issues, it looks like there plenty of issues with regex, isn't any other working library? https://github.com/tedious/JShrink/issues
The text was updated successfully, but these errors were encountered: