Use English consistently for the Swiss regions names

[kassner]

Description

Some of the Swiss regions are using a name that is not in English nor in the official language of the Canton. Source.

Manual testing scenarios

1. On the address create/edit form, select Switzerland as country;
2. There is no Geneve in the regions list.

Questions or comments

Disclaimer: I am not Swiss neither live in the country, I just happen to have a few customers mentioning that the region names weren't straight forward.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Use English consistently for the Swiss regions names #32602: Use English consistently for the Swiss regions names

[m2-assistant]

Hi @kassner. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[gabrieldagama]

@magento create issue

[ihor-sviziev]

@orlangur Removed assignee, as the month already passed and no activity from you, and this is high priority PR

[orlangur]

✅ All Swiss regions checked as per https://en.wikipedia.org/wiki/Cantons_of_Switzerland#Names_in_national_languages

[magento-engcom-team]

Hi @orlangur, thank you for the review.
ENGCOM-9115 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

Hi @kassner , @orlangur
Thanks for the contribution!

❌ QA not Passed

Replaced region names of Swiss are not reflected

Manual Scenario Steps

1. Upgraded to the PR request;
2. Logged into the application front-end;
3. Navigated to the My Account Edit Address;
4. Selected the Switzerland country;
5. Tried to select the state/region;

❌ Actual result

• 

• Found Genf; But not Geneva

✔️ Expected result

• Should be replaced to Geneva
• Other updated names also not reflected

Can you please cross check once about it if it is reflecting from your end @kassner , Or anything more required to update in the code!

[kassner]

Well, this should only work for a fresh install with the code changes. I don't think it's a good idea to create a patch to update already running installations, but you tell me.

[engcom-Alfa]

Preconditions:

1. Require to have this fresh PR fix instance to be installed with sample data.
2. Create a new front end user.

Manual testing scenario:

1. Login to the front end user, and navigate to the My account > Address book section.

2. Select country as "Switzerland" and check all the renamed states

3. Add product to cart and navigate to Shipping address page > Add new shipping address

4. Select country as "Switzerland" and check all the renamed states

Before: ✖️ State names "Freiburg", "Genf", "Luzern", "Neuenburg", "Tessin" and "Waadt" were existing by selecting the country "Switzerland"

After: ✔️ State names "Friburg", "Geneva", "Lucerne", "Neuchâtel", "Ticino" and "Vaud" are existing by selecting the country "Switzerland"

[ihor-sviziev]

@engcom-Alfa, does it works for installations, when we installed Magento on clean 2.4-develop branch, and then switched to this branch?

[engcom-Alfa]

Hi @ihor-sviziev
It works only if we install PR branch directly.
If we first install 2.4-develop working instance and then if we remote-fetch to the PR fix branch, fixed code is still does not work.

[ihor-sviziev]

@engcom-Alfa, I think it should be fixed, as it won’t work for existing magento installations

[engcom-Alfa]

Hi @kassner, As @ihor-sviziev suggested above, it should be fixed even by switching to the PR fix version from 2.4-develop instance. So, I am moving the PR to changes requested. Kindly take a look on it.
Well, even the PR fix should have all the automated scripts passed. Request you to take a look at it as well.

[kassner]

I don't have the energy to deal with this, so closing.

If anyone else wants to work on it, feel free to build on top of my current PR.

[m2-assistant]

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

FYI Here is a follow up PR that fixes this issue #33787

[engcom-Alfa]

Thanks for your contribution @kassner!
Thank you for carrying it forward @ihor-sviziev , I will look into that new PR.