Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Switzerland regions #33787

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented Aug 13, 2021

Description

Update Switzerland regions. This PR replaces #32553

Related Pull Requests

Fixed Issues

Fixes #32602

@m2-assistant
Copy link

m2-assistant bot commented Aug 13, 2021

Hi @sergiy-v. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@magento-engcom-team magento-engcom-team added Component: Directory Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 13, 2021
@sergiy-v
Copy link
Contributor Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Aug 13, 2021
@ihor-sviziev ihor-sviziev added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 13, 2021
@m2-community-project m2-community-project bot removed this from Pending Review in Pull Requests Dashboard Aug 13, 2021
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Aug 13, 2021
@ihor-sviziev ihor-sviziev self-assigned this Aug 13, 2021
@m2-community-project m2-community-project bot moved this from Pending Review to Review in Progress in High Priority Pull Requests Dashboard Aug 13, 2021
@Den4ik Den4ik self-assigned this Aug 13, 2021
@Den4ik Den4ik self-requested a review August 13, 2021 09:04
@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, thank you for the review.
ENGCOM-9180 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-9180 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Aug 13, 2021
@engcom-Alfa engcom-Alfa self-assigned this Aug 13, 2021
@m2-community-project m2-community-project bot moved this from Testing in Progress to Ready for Testing in High Priority Pull Requests Dashboard Aug 13, 2021
@engcom-Alfa engcom-Alfa moved this from Ready for Testing to Testing in Progress in High Priority Pull Requests Dashboard Aug 13, 2021
@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented Aug 16, 2021

✔️ QA Passed

Manual testing scenario:

  1. Created a fresh Magento instance, switch to the PR fix branch.

  2. Login to Admin - Store Configuration address - Select the Switzerland country, and validate the replaced state names

  3. Create a customer in the front end and do login.

  4. Navigate to the My Account > Address book > Add new address - Select the Switzerland country, and validate the replaced state names

  5. Search any product and add do the cart and checkout. Add new shipping address- Select the Switzerland country, and validate the replaced state names

Before: ✖️ A few state names of Switzerland were miss spelled, and are highlighted in the below screenshot.
image

After: ✔️ Miss-spelled state names of Switzerland are corrected properly as shown in below screenshot.
image
image
image

Tested in frontend and Admin side address fields. There is no other additional regression testing is required on this!

@engcom-Alfa engcom-Alfa moved this from Testing in Progress to Merge in Progress in High Priority Pull Requests Dashboard Aug 16, 2021
@magento-engcom-team magento-engcom-team merged commit 74b49e0 into magento:2.4-develop Aug 27, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 27, 2021

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Directory Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue] Use English consistently for the Swiss regions names
5 participants