[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

AnnaAPak · 2021-08-03T09:41:16Z

The test is refactored to improve execution time

Related Pull Requests

Please, note: the test is dependent on #33557

…hOnDeliveryPaymentMethodTest

…ckMoneyOrderPaymentMethodTest

m2-assistant · 2021-08-03T09:41:18Z

Hi @AnnaAPak. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

AnnaAPak · 2021-08-03T09:41:30Z

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

magento-automated-testing · 2021-08-03T09:41:37Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

edenduong

Thank you for your contribution. Please check my comment

edenduong · 2021-08-04T16:59:41Z

...gento/Sales/Test/Mftf/Test/AdminCancelTheCreatedOrderWithCashOnDeliveryPaymentMethodTest.xml

+        </getData>
+        <actionGroup ref="StorefrontOpenMyOrdersPageActionGroup" stepKey="clickOnMyOrders"/>
+        <comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="waitForOrderDetailsToLoad"/>
+        <seeElement selector="{{StorefrontCustomerOrderViewSection.orderStatusInGrid('$createCustomerCart.increment_id$', 'Canceled')}}" stepKey="seeOrderStatusInGrid"/>


I think can move to action group with argument

Hi @edenduong I have created the separate PR for this Action Group - please check #33727.
I have updated other tests with it as well.

These changed are within the initial PR and there are some more PR depended on it.

Please let me know if you are ok with such approach.

edenduong · 2021-08-04T16:59:53Z

app/code/Magento/Sales/Test/Mftf/Test/StorefrontOrderCommentWithHTMLTagsDisplayTest.xml

+
+        <actionGroup ref="StorefrontClickViewOrderLinkOnMyOrdersPageActionGroup" stepKey="clickViewOrder"/>
+
+        <dontSee userInput="{{anchorTagFragment.anchorTag}}" selector="{{StorefrontCustomerOrderViewSection.orderComment}}" stepKey="dontSeeExposedHtmlCode"/>


I think can move to action group

@edenduong I checked - there are no more tests that use this assertion. Do you think we still need create a separate Action Group here?
Thanks.

@AnnaAPak It could be groundwork for the future :)

Den4ik · 2021-08-19T12:12:15Z

@magento run all tests

engcom-Charlie · 2021-11-10T12:19:32Z

Hi @AnnaAPak,

Thank you for your contribution!

Will look into the conflicts.

Thank you!

engcom-Charlie · 2021-11-10T12:20:56Z

It seems that Bot moved this ticket to Ready for testing automatically so moving it back to Change Requested.

engcom-Charlie · 2021-11-12T13:17:48Z

@magento run all tests

magento-automated-testing · 2021-11-12T13:17:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-15T11:45:47Z

@magento run all tests

magento-automated-testing · 2021-11-15T11:45:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-16T06:57:50Z

@magento run all tests

magento-automated-testing · 2021-11-16T06:57:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-16T10:33:49Z

@magento run Functional Tests B2B

magento-automated-testing · 2021-11-16T10:33:54Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

engcom-Charlie · 2021-11-16T13:48:20Z

I have merged 2.4-develop into this branch and ran the tests.

Since the build is green now and PR is about MFTF test cases, moving this directly to Merge in Progress.

Thank you!

…est #33667

AnnaAPak added 4 commits July 22, 2021 09:45

refactored to decrease execution time

e6ed808

Merge branch '2.4-develop' into ref-AdminCancelTheCreatedOrderWithCas…

24c3210

…hOnDeliveryPaymentMethodTest

Merge branch '2.4-develop' into ref-AdminCancelTheCreatedOrderWithChe…

778b802

…ckMoneyOrderPaymentMethodTest

refactored StorefrontVerifyOrderHistoryCommentsTest

4c8908f

magento-engcom-team added Component: Backend Component: Quote Component: Sales Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 3, 2021

edenduong self-requested a review August 4, 2021 16:58

edenduong requested changes Aug 4, 2021

View reviewed changes

m2-community-project bot assigned edenduong Aug 4, 2021

m2-community-project bot added this to Changes Requested in Pull Requests Dashboard Aug 4, 2021

m2-community-project bot added the Progress: needs update label Aug 4, 2021

edenduong added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Progress: needs update labels Aug 4, 2021

sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 5, 2021

m2-community-project bot added this to Changes Requested in High Priority Pull Requests Dashboard Aug 5, 2021

m2-community-project bot removed this from Changes Requested in Pull Requests Dashboard Aug 5, 2021

m2-community-project bot added the Progress: needs update label Aug 5, 2021

Den4ik self-requested a review August 6, 2021 12:05

Den4ik self-assigned this Aug 6, 2021

m2-community-project bot moved this from Changes Requested to Review in Progress in High Priority Pull Requests Dashboard Aug 12, 2021

m2-community-project bot added Progress: review and removed Progress: needs update labels Aug 12, 2021

m2-community-project bot added the Progress: ready for testing label Nov 10, 2021

engcom-Charlie moved this from Ready for Testing to Changes Requested in High Priority Pull Requests Dashboard Nov 10, 2021

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Nov 10, 2021

33667 Merged 2.4-develop and resolved conflicts

550115b

33667 Merged 2.4-develop and resolved conflicts

00d9a6b

engcom-Charlie moved this from Changes Requested to Merge in Progress in High Priority Pull Requests Dashboard Nov 16, 2021

m2-community-project bot added Progress: accept and removed Progress: needs update labels Nov 16, 2021

magento-engcom-team removed the Component: Backend label Nov 16, 2021

m2-community-project bot moved this from Merge in Progress to Ready for Testing in High Priority Pull Requests Dashboard Nov 16, 2021

m2-community-project bot added Progress: ready for testing and removed Progress: accept labels Nov 16, 2021

sidolov moved this from Ready for Testing to Merge in Progress in High Priority Pull Requests Dashboard Nov 24, 2021

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Nov 24, 2021

magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 3, 2022

ENGCOM-9277: [MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsT…

93cce98

…est #33667

magento-devops-reposync-svc merged commit 518a56f into magento:2.4-develop Feb 3, 2022

sidolov moved this from Merge in Progress to Recently Merged in High Priority Pull Requests Dashboard Mar 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

AnnaAPak commented Aug 3, 2021

m2-assistant bot commented Aug 3, 2021

AnnaAPak commented Aug 3, 2021

magento-automated-testing bot commented Aug 3, 2021

edenduong left a comment

edenduong Aug 4, 2021

AnnaAPak Aug 12, 2021

edenduong Aug 4, 2021

AnnaAPak Aug 12, 2021

Den4ik Aug 12, 2021

Den4ik commented Aug 19, 2021

engcom-Charlie commented Nov 10, 2021

engcom-Charlie commented Nov 10, 2021

engcom-Charlie commented Nov 12, 2021

magento-automated-testing bot commented Nov 12, 2021

engcom-Charlie commented Nov 15, 2021

magento-automated-testing bot commented Nov 15, 2021

engcom-Charlie commented Nov 16, 2021

magento-automated-testing bot commented Nov 16, 2021

engcom-Charlie commented Nov 16, 2021

magento-automated-testing bot commented Nov 16, 2021

engcom-Charlie commented Nov 16, 2021


		<actionGroup ref="StorefrontClickViewOrderLinkOnMyOrdersPageActionGroup" stepKey="clickViewOrder"/>

		<dontSee userInput="{{anchorTagFragment.anchorTag}}" selector="{{StorefrontCustomerOrderViewSection.orderComment}}" stepKey="dontSeeExposedHtmlCode"/>

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

[MFTF] Refactoring StorefrontVerifyOrderHistoryCommentsTest #33667

Conversation

AnnaAPak commented Aug 3, 2021

Related Pull Requests

m2-assistant bot commented Aug 3, 2021

AnnaAPak commented Aug 3, 2021

magento-automated-testing bot commented Aug 3, 2021

edenduong left a comment

Choose a reason for hiding this comment

edenduong Aug 4, 2021

Choose a reason for hiding this comment

AnnaAPak Aug 12, 2021

Choose a reason for hiding this comment

edenduong Aug 4, 2021

Choose a reason for hiding this comment

AnnaAPak Aug 12, 2021

Choose a reason for hiding this comment

Den4ik Aug 12, 2021

Choose a reason for hiding this comment

Den4ik commented Aug 19, 2021

engcom-Charlie commented Nov 10, 2021

engcom-Charlie commented Nov 10, 2021

engcom-Charlie commented Nov 12, 2021

magento-automated-testing bot commented Nov 12, 2021

engcom-Charlie commented Nov 15, 2021

magento-automated-testing bot commented Nov 15, 2021

engcom-Charlie commented Nov 16, 2021

magento-automated-testing bot commented Nov 16, 2021

engcom-Charlie commented Nov 16, 2021

magento-automated-testing bot commented Nov 16, 2021

engcom-Charlie commented Nov 16, 2021