-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented order by in ChangeLogBatchWalker classes #37399
base: 2.4-develop
Are you sure you want to change the base?
Implemented order by in ChangeLogBatchWalker classes #37399
Conversation
Hi @dudzio12. Thank you for your contribution! Add the comment under your pull request to deploy test or vanilla Magento instance:
❗ Automated tests can be triggered manually with an appropriate comment:
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Failed static test is not related to this pr. |
I thinks that SQL approach is better for walking the changelog. So based on your PR and other comments i prepared PoC patches that works fine at my project |
@ilnytskyi, maybe you can create a Pull Request? |
Description (*)
When there is no order by provided in select query, the actual order of records is unspecified and it cannot be assumed that records will sort by PRIMARY key. The only way to guarantee sorting by primary key is to set it inside the select query.
Tested on Magento 2.4.5-p2 and MariaDB 10.3.38:
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)