Implemented order by in ChangeLogBatchWalker classes

[dudzio12]

Description (*)

When there is no order by provided in select query, the actual order of records is unspecified and it cannot be assumed that records will sort by PRIMARY key. The only way to guarantee sorting by primary key is to set it inside the select query.

Tested on Magento 2.4.5-p2 and MariaDB 10.3.38:

SELECT DISTINCT  `version_id`, `catalogrule_product_cl`.`entity_id` FROM `catalogrule_product_cl` WHERE (version_id > 45098858) AND (version_id <= 45127404) GROUP BY `entity_id` LIMIT 1000;
// MIN VERSION ID: 45104304 | MAX VERSION ID: 45122597

SELECT DISTINCT  `version_id`, `catalogrule_product_cl`.`entity_id` FROM `catalogrule_product_cl` WHERE (version_id > 45098858) AND (version_id <= 45127404) GROUP BY `entity_id` ORDER BY `version_id` ASC LIMIT 1000;
// MIN VERSION ID: 45098859 | MAX VERSION ID: 45099858

SELECT DISTINCT  `version_id`, `catalogrule_product_cl`.`entity_id` FROM `catalogrule_product_cl` WHERE (version_id > 45098858) AND (version_id <= 45127404) GROUP BY `entity_id` ORDER BY `version_id` DESC LIMIT 1000;
// MIN VERSION ID: 45117648 | MAX VERSION ID: 45126352

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Indexation in scheduled mode might loose some ids when indexing #37398

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @dudzio12. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[dudzio12]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dudzio12]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[dudzio12]

Failed static test is not related to this pr.

[ilnytskyi]

I thinks that SQL approach is better for walking the changelog. So based on your PR and other comments i prepared PoC patches that works fine at my project
#30012 (comment)

[ihor-sviziev]

@ilnytskyi, maybe you can create a Pull Request?