Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indexation in scheduled mode might loose some ids when indexing #37398

Closed
5 tasks
dudzio12 opened this issue Apr 19, 2023 · 7 comments · May be fixed by #37399
Closed
5 tasks

Indexation in scheduled mode might loose some ids when indexing #37398

dudzio12 opened this issue Apr 19, 2023 · 7 comments · May be fixed by #37399
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@dudzio12
Copy link
Member

Preconditions and environment

  • Magento version 2.4.* (This bug is very old though)
  • Indexes in scheduled mode

Steps to reproduce

  1. Add more than 1000 ids to any _cl table.
  2. Run indexer in mview mode, for example by running cron job indexer_update_all_views.

Expected result

All 1000+ ids should be indexed.

Actual result

Some ids might not be indexed. This is because there is no sort order implemented in both ChangeLogBatchWalker classes logic.

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Apr 19, 2023

Hi @dudzio12. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@dudzio12
Copy link
Member Author

I'm working on this

@ihor-sviziev
Copy link
Contributor

I think this is pretty related to #30012 and #37367.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Apr 20, 2023
@dudzio12
Copy link
Member Author

@ihor-sviziev - Not necessarily, this will not fix the issue with duplicated ids added to _cl table. The best way to fix it completely would probably be changing batching responsibility to PHP with array_unique instead of MysQL.

@m2-community-project m2-community-project bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 2, 2023
@engcom-Bravo engcom-Bravo added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label May 17, 2023
@engcom-Hotel engcom-Hotel self-assigned this Jul 21, 2023
@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2023

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @dudzio12,

Thanks for the report and collaboration!

We tried to reproduce this issue in the 2.4-develop branch and it seems the issue is not reproducible for us. For us we have more than 1000 entries in the _cl table and all are indexed.

I agree with @ihor-sviziev, that the issue is related to #30012, and this issue is already confirmed.

As per my comment here on this issue #30012 (comment), the SQL query always returns the same id to index, due to which indexing for all the records is not happening.

Please let us know if we missed anything.

Thanks

@engcom-Hotel engcom-Hotel added the Issue: needs update Additional information is require, waiting for response label Jul 21, 2023
@engcom-Hotel
Copy link
Contributor

Dear @dudzio12 ,

We have noticed that this issue has not been updated for a long time. Hence we assume that this issue is fixed now, so we are closing it. Please raise a fresh ticket or reopen this ticket if you need more assistance on this.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Development

Successfully merging a pull request may close this issue.

4 participants