magento/magento2#7279 bill-to name and ship-to name truncated to 20 chars #9654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bill-to Name and Ship-to Name trancated to 20 characters in backend Compared the lengths of firstname, middlename and lastname of table "quote_address" with those of "quote" (255, 40 and 255 resp.) and of "sales_order_address" (255, 255 and 255) and with sales_order (128, 128 and 128) and choose to go with 255, 40 and 255 since these are used in "quote" as well and these are the values I know from Magento 1.9 as well. The other values are a bit inconsistent. Tested.
| @@ -46,6 +46,43 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con | |||
| ] | |||
| ); | |||
| } | |||
|
|
|||
| if (version_compare($context->getVersion(), '2.0.2', '<')) { | |||
There was a problem hiding this comment.
You may move all the updates into a single if statement
Bill-to Name and Ship-to Name trancated to 20 characters in backend Compared the lengths of firstname, middlename and lastname of table "quote_address" with those of "quote" (255, 40 and 255 resp.) and of "sales_order_address" (255, 255 and 255) and with sales_order (128, 128 and 128) and choose to go with 255, 40 and 255 since these are used in "quote" as well and these are the values I know from Magento 1.9 as well. The other values are a bit inconsistent. Tested. Updated setup version of the Quote module to 2.0.5, moved all updates into a single if statement.
|
All updates are now moved into one if statement (and placed after the last update if statement) and the setup version of the Quote module is now 2.0.5 |
ishakhsuvarov
approved these changes
May 22, 2017
ishakhsuvarov
added
approved
Progress: accept
and removed
approved
Progress: needs update
labels
magento-team
pushed a commit
that referenced
this pull request
May 27, 2017
…ars #9654 - Merge conflict resolved
magento-team
pushed a commit
that referenced
this pull request
May 27, 2017
magento-team
pushed a commit
that referenced
this pull request
May 27, 2017
[EngCom] Public Pull Requests - MAGETWO-69379 use payment method name to make checkbox of agreements more unique #6207 #9717 - MAGETWO-69378 #4272: v2.0.4 Credit memos with adjustment fees cannot be fully refunded with a second credit memo #9715 - MAGETWO-69375 Can't delete last item in cart if Minimum Order is Enable #6151 #9714 - MAGETWO-69230 #7279 bill-to name and ship-to name truncated to 20 chars #9654 - MAGETWO-69155 Fix coding standard in Magento AdminNotification module #9627
|
@SolsWebdesign thank you for your contribution to Magento 2 project |
1 similar comment
|
@SolsWebdesign thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bill-to Name and Ship-to Name truncated to 20 characters in backend
The firstname, middlename and lastname in table "quote_address" were set to a length of 20.
I compared the lengths of firstname, middlename and lastname of table "quote_address" with those of "quote" (255, 40 and 255 resp.) and of "sales_order_address" (255, 255 and 255) and with sales_order (128, 128 and 128) and choose to go with 255, 40 and 255 since these are used in "quote" as well and these are the values I know from Magento 1.9 as well. The other values seem a bit inconsistent.
Description
In Magento\Quote\Setup\UpgradeSchema.php there was already a repair for street so I added the repairs for the lengths of firstname, lastname and middlename in the same way and tested.
Fixed Issues (if relevant)
#7279 : bill-to name and ship-to name truncated to 20 chars
Manual testing scenarios
Use composer install from the develop branch and after composer install, update the new Magento\Quote\Setup\UpgradeSchema.php. Go through the steps to install Magento further and when done, check the database table "quote_address". The columns firstname, middlename and lastname are now 255, 40 and 255 in length.
Contribution checklist