Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coding standard in Magento AdminNotification module #9627

Merged
merged 2 commits into from
May 27, 2017
Merged

Fix coding standard in Magento AdminNotification module #9627

merged 2 commits into from
May 27, 2017

Conversation

dverkade
Copy link
Member

@dverkade dverkade commented May 13, 2017 •
edited by ishakhsuvarov
Loading

Fix coding standard in Magento AdminNotification module:

  • Removed @codingStandardsIgnoreFile from head of the file.
  • Fixed max line length
  • Fixed closing parenthesis of a multi-line function call must be on a line by itself

@dverkade
Fix coding standard violations:
c9bd736 
- Removed @codingStandardsIgnoreFile from head of the file.
- Fixed max line length
-
@dverkade
Fixed closing parenthesis of a multi-line function call must be on a …
84a002b 
…line by itself
@ishakhsuvarov ishakhsuvarov self-assigned this May 14, 2017
@ishakhsuvarov ishakhsuvarov added this to the May 2017 milestone May 14, 2017
@orlangur
Copy link
Contributor

@ishakhsuvarov this module and many other are already covered by #9367, could you please start processing from it instead of useless manual changes?

@magento-team magento-team merged commit 84a002b into magento:develop May 27, 2017
magento-team pushed a commit that referenced this pull request May 27, 2017
@ishakhsuvarov
MAGETWO-69155: Fix coding standard in Magento AdminNotification module …
37c47fa 
…#9627
magento-team pushed a commit that referenced this pull request May 27, 2017
@ishakhsuvarov
Merge pull request #1142 from magento-engcom/develop-prs
8e21d5a 
[EngCom] Public Pull Requests
 - MAGETWO-69379 use payment method name to make checkbox of agreements more unique #6207 #9717
 - MAGETWO-69378 #4272: v2.0.4 Credit memos with adjustment fees cannot be fully refunded with a second credit memo #9715
 - MAGETWO-69375 Can't delete last item in cart if Minimum Order is Enable #6151 #9714
 - MAGETWO-69230 #7279 bill-to name and ship-to name truncated to 20 chars #9654
 - MAGETWO-69155 Fix coding standard in Magento AdminNotification module #9627
@magento-team
Copy link
Contributor

@dverkade thank you for your contribution. Your Pull Request has been successfully merged

@magento-team
Copy link
Contributor

@dverkade thank you for your contribution to Magento 2 project

@orlangur
Copy link
Contributor

orlangur commented Jun 6, 2017

@ishakhsuvarov hmmm, why waste time on merging changes already covered by earlier PRs?

@ishakhsuvarov
Copy link
Contributor

@orlangur hmmm, maybe because it is not as time-consuming as reviewing changeset of thousands of files?
Yes, I think that is the reason.

@korostii
Copy link
Contributor

korostii commented Jun 7, 2017

reviewing changeset of thousands of files
time-consuming

Right... And yet the copyright line has to be updated each year throughout the code.

@orlangur
Copy link
Contributor

@ishakhsuvarov there is no need to review autogenerated commits manually.

@korostii just was not backported to 2.1, if 2.1 will still be relevant in January 2018 I think there will be commit with year removal. And yeah, good example, copyright year removal commit does not require manual review as well :)

@dverkade dverkade deleted the Fix_coding_standard_in_Magento-AdminNotification branch June 22, 2018 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
None yet
Projects
None yet
Milestone
May 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@dverkade @orlangur @magento-team @ishakhsuvarov @korostii