Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump apollo-server from 2.6.9 to 2.14.2 #2464

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 6, 2020

Bumps apollo-server from 2.6.9 to 2.14.2.

Changelog

Sourced from apollo-server's changelog.

v2.14.2

Note: This release is is related to a GitHub Security Advisory published by the Apollo Server team. Please read the attached advisory to understand the impact.

v2.14.1

See complete versioning details.

v2.14.0

See complete versioning details.

  • apollo-server-core / apollo-server-plugin-base: Add support for willResolveField and corresponding end-handler within executionDidStart. This brings the remaining bit of functionality that was previously only available from graphql-extensions to the new plugin API. The graphql-extensions API (which was never documented) will be deprecated in Apollo Server 3.x. To see the documentation for the request pipeline API, see its documentation. For more details, see the attached PR. [PR #3988](apollographql/apollo-server#3988)

  • apollo-server-core: Deprecate graphql-extensions. All internal usages of the graphql-extensions API have been migrated to the request pipeline plugin API. For any implementor-supplied extensions, a deprecation warning will be printed once per-extension, per-server-startup, notifying of the intention to deprecate. Extensions should migrate to the plugin API, which is outlined in its documentation. [PR #4135](apollographql/apollo-server#4135)

  • apollo-engine-reporting: Currently only for non-federated graphs. Added an experimental schema reporting option, experimental_schemaReporting, for Apollo Graph Manager users. During this experiment, we'd appreciate testing and feedback from current and new users of the schema registry!

    Prior to the introduction of this feature, the only way to get schemas into the schema registry in Apollo Graph Manager was to use the CLI and run apollo schema:push. Apollo schema reporting protocol is a new specification for GraphQL servers to automatically report schemas to the Apollo Graph Manager schema registry.

    To enable schema reporting, provide a Graph Manager API key (available free from Apollo Graph Manager) in the APOLLO_KEY environment variable and set the experimental_schemaReporting option to true in the Apollo Server constructor options, like so:

    const server = new ApolloServer({
      typeDefs,
      resolvers,
      engine: {
        experimental_schemaReporting: true,
        /* Other existing options can remain the same. */
      },
    });

    When enabled, a schema reporter is initiated by the apollo-engine-reporting agent. It will loop until the ApolloServer instance is stopped, periodically calling back to Apollo Graph Manager to send information. The life-cycle of this reporter is managed by the agent.

    For more details on the implementation of this new protocol, see the PR which introduced it to Apollo Server and the preview documentation.

... (truncated)
Commits
  • a17f26b Release
  • 7aaca56 Update @apollo/gateway and @apollo/federation CHANGELOG before publish.
  • 354d991 Update CHANGELOG.md for subscription validation rules to Security Advisory.
  • 04fab28 Merge remote-tracking branch 'origin/master' into advisory-fix-1
  • 02f1fb6 chore(deps): update dependency gatsby to v2.22.15 (#4187)
  • eadbfc3 chore(deps): update dependency gatsby to v2.22.13 (#4181)
  • d979a9e chore(deps): update dependency @types/lodash to v4.14.154 (#4184)
  • 68ff8e5 chore(deps): update dependency ioredis to v4.17.3 (#4182)
  • 00a056a chore(deps): update dependency @types/lodash to v4.14.153 (#4180)
  • c0aa7c0 chore(deps): update dependency @azure/functions to v1.2.2 (#4179)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jun 6, 2020
@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Jun 6, 2020
@PWAStudioBot PWAStudioBot added the pkg:upward-spec Pertains to UPWARD specification package. label Jun 6, 2020
@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Jun 6, 2020

Fails
🚫 Missing "Description" section. Please add it back, with detail.
🚫 Missing "Verification Steps" section. Please add it back, with detail.
🚫

No linked issue found. Please link a relevant open issue by adding the text "closes #<issue_number>" or "closes JIRA-<issue_number>" in your PR.

🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

If your PR is missing information, check against the original template here. At a minimum you must have the section headers from the template and provide some information in each section.

Generated by 🚫 dangerJS against a5aab54

@devops-pwa-codebuild
Copy link
Collaborator

devops-pwa-codebuild commented Jun 6, 2020

Performance Test Results

The following fails have been reported by WebpageTest. These numbers indicates a possible performance issue with the PR which requires further manual testing to validate.

https://pr-2464.pwa-venia.com : LH Performance Expected 0.85 Actual 0.53, LH Best Practices Expected 1 Actual 0.92
https://pr-2464.pwa-venia.com/venia-tops.html : LH Performance Expected 0.75 Actual 0.32, LH Best Practices Expected 1 Actual 0.92
https://pr-2464.pwa-venia.com/valeria-two-layer-tank.html : LH Performance Expected 0.8 Actual 0.49, LH Accessibility Expected 0.9 Actual 0.89, LH Best Practices Expected 1 Actual 0.92

@sirugh
Copy link
Contributor

sirugh commented Jun 8, 2020

We may be able to remove apollo-server from our dependencies. It is only exported from upward-spec as MockGQLService but I don't see any use of it anywhere. @zetlen do you recall this export? Can we safely remove it and the dependency?

@zetlen
Copy link
Contributor

zetlen commented Jun 8, 2020

Heck! Nice catch, @sirugh, we can absolutely yank it.

Signed-off-by: sirugh <rugh@adobe.com>
@sirugh
Copy link
Contributor

sirugh commented Jun 8, 2020

OK, I have removed apollo-server and its use entirely :)

Copy link
Contributor

@zetlen zetlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good looking out @sirugh

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jun 8, 2020
@dpatil-magento dpatil-magento merged commit 993197c into develop Jun 8, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jun 8, 2020
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/apollo-server-2.14.2 branch June 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pkg:upward-spec Pertains to UPWARD specification package.
Development

Successfully merging this pull request may close these issues.

None yet

6 participants