Skip to content

security-package/issues/104: "Enable Invisible reCAPTCHA in Newsletter Subscription" should not be shown for not supported types of reCAPTCHA. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

security-package/issues/104: "Enable Invisible reCAPTCHA in Newsletter Subscription" should not be shown for not supported types of reCAPTCHA. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ReCaptchaAdminUi/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
showInStore="0" canRestore="1">
<label>Score Threshold</label>
<depends>
<field id="recaptcha/general/type">recaptcha_v3</field>
<field id="recaptcha/frontend/type">recaptcha_v3</field>
</depends>
<comment>From 0.0 to 1.0, where 0.0 is absolutely a robot and 1.0 is a human.</comment>
</field>
Expand Down
3 changes: 2 additions & 1 deletion ReCaptchaNewsletter/etc/adminhtml/system.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,11 @@
<field id="enabled_for_newsletter" translate="label" type="select" sortOrder="250" showInDefault="1"
showInWebsite="1" showInStore="0" canRestore="1">
<label>Use invisible ReCaptcha in newsletter</label>
<comment>Requires an Invisible ReCaptcha v2 or ReCaptcha v3 key. If enabled, a badge will be displayed in every page.</comment>
<comment>Requires an Invisible reCAPTCHA v2 or v3 key.</comment>
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
<depends>
<field id="enabled">1</field>
<field id="recaptcha/frontend/type" negative="1">recaptcha</field>
</depends>
</field>
</group>
Expand Down