security-package/issues/123: reCAPTCHA adapters modularity #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engcom-Foxtrot
force-pushed
the
security-package/issues/123
branch
from
56e100b to
18e1acd
Compare
naydav
force-pushed
the
security-package/issues/86
branch
from
d8789f3 to
09ac3bb
Compare
naydav
changed the base branch from
security-package/issues/86
to
1.0-develop
…ge/issues/123 # Conflicts: # ReCaptchaAdminUi/Model/CaptchaConfig.php # ReCaptchaAdminUi/etc/adminhtml/system.xml # ReCaptchaApi/Model/Config/Source/Type.php # ReCaptchaFrontendUi/Model/CaptchaConfig.php # ReCaptchaInvisibleVersion3/etc/config.xml # ReCaptchaVersion2/etc/config.xml
engcom-Foxtrot
force-pushed
the
security-package/issues/123
branch
from
4d08193 to
2de6064
Compare
This was referenced Mar 9, 2020
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 3, 2023
L3 pr 2023 09 13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123
Refactoring of
https://github.com/magento/security-package/blob/security-package/issues/86/ReCaptchaApi/Model/Config/Source/Type.php#L26All of the captcha types should be injected via
__constructEach of module from spet 1 should provide own type
All of options providers (
security-package/ReCaptchaApi/Model/Config/Source) should be located in corresponding moduleA git branch based on
security-package/issues/86