Skip to content

security-package/issues/171: Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 27, 2020
Merged

security-package/issues/171: Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings #172

merged 4 commits into from
May 27, 2020

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

  • Updated system.xml

  • Added default values, created config.xml

  • Updated translate file (i18n), was removed unused value

Fixed Issues (if relevant)

  1. Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings #171: Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sdzhepa sdzhepa linked an issue Apr 14, 2020 that may be closed by this pull request
Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings #171
Closed
@lenaorobei lenaorobei changed the base branch from 1.0-develop to 1.0.0-develop May 20, 2020 19:49
@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei lenaorobei added this to the 1.0.0 milestone May 20, 2020
lenaorobei
lenaorobei previously approved these changes May 21, 2020
View reviewed changes
@lenaorobei
Copy link
Contributor

@magento run all tests

@engcom-Delta engcom-Delta self-assigned this May 22, 2020
@engcom-Delta
Copy link

✔️ QA passed
Result:
image

@lenaorobei
Copy link
Contributor

@magento run Unit Tests, Functional Tests B2B

@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento run Database Compare

@lenaorobei
Copy link
Contributor

@magento run Functional Tests B2B

@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento run Static Tests

@lenaorobei
Copy link
Contributor

@magento run Static Tests, Functional Tests EE, Functional Tests B2B

@lenaorobei lenaorobei merged commit 0092b51 into 1.0.0-develop May 27, 2020
@lenaorobei lenaorobei deleted the security-package/issues/171 branch June 10, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naydav naydav Awaiting requested review from naydav

@engcom-Foxtrot engcom-Foxtrot Awaiting requested review from engcom-Foxtrot

1 more reviewer

@lenaorobei lenaorobei lenaorobei left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@lenaorobei lenaorobei

@engcom-Delta engcom-Delta

Labels
Component: Admin Component: securitytxt
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Default(pre-filled) value should be added to the "Policy" in Admin Panel for Security.txt settings
3 participants
@engcom-Kilo @lenaorobei @engcom-Delta