Skip to content

security-package/issues/189: Updated CSS styles. #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2020
Merged

security-package/issues/189: Updated CSS styles. #190

merged 1 commit into from
Apr 6, 2020

Conversation

engcom-Kilo
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Wrong aliment for reCAPCTHA inline block on Admin Login page for v2 Invisible and v3 #189: Wrong aliment for reCAPCTHA inline block on Admin Login page for v2 Invisible and v3

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Author has signed the Adobe CLA
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@engcom-Kilo engcom-Kilo added Component: Admin Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label labels Apr 3, 2020
@engcom-Delta engcom-Delta self-assigned this Apr 3, 2020
@engcom-Delta
Copy link

✔️ QA passed
Result with fix:
#190PRv2NotARobotLogin
#190PRv2NotARobotForgot
#190PRInvisibleLogin
#190PRInvisibleForgot

@naydav
Copy link
Contributor

naydav commented Apr 3, 2020 •
edited
Loading

@engcom-Delta

Please check view with different types of reCAPTCHA, also normal/compact size of reCAPTCHA v2 ("I am not a robot")
Thanks

@engcom-Delta
Copy link

@naydav
Result with compact size of reCAPTCHA v2 ("I am not a robot"):
image

image

Result with normal size of reCAPTCHA v2 ("I am not a robot"):
image

image

Result with Login=reCAPTCHA v2 ("I am not a robot") and Forgot Password=reCAPTCHA v2-v3 nvisible
image

image

Result with Login=reCAPTCHA v2-v3 nvisible and Forgot Password=reCAPTCHA v2 ("I am not a robot")
image

image

@naydav naydav merged commit 71e77b3 into 1.0-develop Apr 6, 2020
@naydav naydav mentioned this pull request Apr 6, 2020
Closed
@naydav naydav deleted the security-package/issues/189 branch April 7, 2020 03:05
@sdzhepa sdzhepa mentioned this pull request Apr 9, 2020
Closed
9 tasks
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 11, 2025
@pawan-adobe-security
Merge pull request #190 from magento-gl/AC-13306-recaptcha-v1
c3a71b2 
Replaced magento/recaptcha with phpfui/recaptcha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@naydav naydav naydav approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@naydav naydav

@engcom-Delta engcom-Delta

Labels
Component: Admin Component: Google reCAPTCHA Issues and Pull Requests related to reCAPTCHA should be marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@engcom-Kilo @engcom-Delta @naydav