security-package/issues/188: Added Notice message to system.xml. #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engcom-Kilo
added
Component: Admin
Component: Google reCAPTCHA
lenaorobei
reviewed
May 20, 2020
| <group id="type_for"> | ||
| <field id="recaptcha_frontend_info_heading" translate="label" sortOrder="100" showInDefault="1" | ||
| showInWebsite="1" showInStore="0"> | ||
| <frontend_model>Magento\ReCaptchaAdminUi\Block\Adminhtml\System\Config\Form\Field\Notice</frontend_model> |
There was a problem hiding this comment.
Need to move this to system.xml of ReCaptchaAdminUi module.
lenaorobei
reviewed
May 20, 2020
| <field id="user_login" translate="label" type="select" sortOrder="100" showInDefault="1" | ||
| <field id="recaptcha_backend_info_heading" translate="label" sortOrder="100" showInDefault="1" | ||
| showInWebsite="0" showInStore="0" > | ||
| <frontend_model>Magento\ReCaptchaAdminUi\Block\Adminhtml\System\Config\Form\Field\Notice</frontend_model> |
|
@magento run all tests |
|
@engcom-Kilo Word "Important" in notice for Google reCAPTCHA Admin Panel is black instead of red Could you take a look? |
Updated CSS styles. |
|
@magento run all tests |
|
✔️ QA passed
|
|
@magento run all tests |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 9, 2025
Merge pull request #194 from magento-cia/cia-2.4.8-develop-2.4-develo…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)