Notifier Modules #2

phoenix128 · 2019-07-31T15:47:15Z

MageSpecialist Notifier modules for Magento 2

hostep · 2019-08-01T11:19:31Z

@phoenix128, just FYI, the composer version constraint ^7.2|^7.3 for php is not really correct here I think, because it boils down to: 7.2.0 ... 7.9999.9999.
And it would be the exact same if you would have used ^7.2 or ^7.2.0

What you probably want is: ~7.2.0 || ~7.3.0 which means: 7.2.0 ... 7.3.9999
(I'm also using double pipes as that's the more correct meaning of or in these constraints, the single pipe was recommended many years ago but is now no longer recommended, but it also won't disappear in the foreseeable future)

More info: https://getcomposer.org/doc/articles/versions.md

phoenix128 · 2019-08-01T12:04:41Z

@hostep ,
ops, you are totally right! I am fixing it.

NotifierTemplateApi/composer.json

NotifierTemplateApi/etc/module.xml

NotifierTemplateApi/README.md

NotifierTemplateApi/Api/DatabaseTemplateRepositoryInterface.php

NotifierTemplateApi/Model/VariablesDecorator/DecorateVariablesInterface.php

NotifierTemplateApi/Api/Data/DatabaseTemplateInterface.php

NotifierTemplateAdminUi/Controller/Adminhtml/DatabaseTemplate/Save.php

Notifier/Model/IsEnabled.php

Notifier/Model/ChannelRepository.php

Notifier/composer.json

Notifier/Model/Serializer.php

Notifier/README.md

Notifier/Test/Integration/Mock/ConfigureMockAdapter.php

Notifier/Test/Integration/_files/channels.php

Notifier/etc/config.xml

NotifierAdminUi/etc/module.xml

NotifierApi/Api/Data/ChannelInterface.php

NotifierApi/README.md

YevSent · 2019-08-05T16:58:15Z

NotifierEmailAdapter/Model/AdapterEngine/Email.php

+    /**
+     * Adapter code for email adapter
+     */
+    public const ADAPTER_CODE = 'email';


Does it make sense to mark these constants as public?

It is referenced here for example: \MSP\NotifierEmailAdapterAdminUi\Ui\DataProvider\Form\Channel\Modifier\Email the idea is to create a hard dependency through constants when a specific adapter is required.

NotifierEmailAdapterAdminUi/Ui/DataProvider/Form/Channel/Modifier/Email.php

NotifierEvent/Test/Integration/ThrottleTest.php

NotifierTemplate/Model/DatabaseTemplate/Command/Save.php

NotifierTemplate/Model/ResourceModel/DatabaseTemplate.php

NotifierTemplate/Model/VariablesDecorator/AdminVariables.php

NotifierTemplate/Test/Integration/_files/db_templates.php

Notifier/Model/ResourceModel/Channel/Collection.php

Notifier/COPYING.txt

NotifierApi/COPYING.txt

magento-cicd2 · 2019-08-20T21:13:49Z

All committers have signed the CLA.

…ateVariablesInterface refactor

…-2.3-develop

[Arrows] MC-34292: AdminCreateUserRoleWithReportsActionGroup needs to be refactored to be based in CE

CABPI-397: Fix Failed Functional Tests CE Tests

phoenix128 added 2 commits July 31, 2019 17:41

Init

e797717

Merge branch 'master' into 2.3-develop

011d720

phoenix128 force-pushed the 2.3-develop branch from 2d2d86c to 011d720 Compare July 31, 2019 15:50

okorshenko assigned YevSent and sidolov Jul 31, 2019

okorshenko requested review from YevSent and sidolov July 31, 2019 18:19

FIX PHP version and Magento2 version in composer.json

8de1e7b

phoenix128 force-pushed the 2.3-develop branch from ee03c2e to 8de1e7b Compare August 1, 2019 12:07

YevSent reviewed Aug 1, 2019

View reviewed changes

hostep reviewed Aug 3, 2019

View reviewed changes

Notifier/composer.json Outdated Show resolved Hide resolved

YevSent reviewed Aug 5, 2019

View reviewed changes

NotifierEvent/Test/Integration/ThrottleTest.php Outdated Show resolved Hide resolved

YevSent reviewed Aug 6, 2019

View reviewed changes

sidolov requested changes Aug 16, 2019

View reviewed changes

Notifier/Model/ResourceModel/Channel/Collection.php Outdated Show resolved Hide resolved

Notifier/COPYING.txt Outdated Show resolved Hide resolved

NotifierApi/COPYING.txt Outdated Show resolved Hide resolved

magento#2: Review fixes

8881b0b

Stanislav Idolov and others added 11 commits August 23, 2019 13:59

magento#2: Changed namespaces; Fixed composer files

e7ab7c5

magento#2: Fixed template validator

4fb08fd

Notifier module should start as disabled

d36241f

FIX version contraint for Magento 2.3.x

2bef913

FIX composer json

bd348fd

FIX errors introduced by public to private constants rework and Decor…

632eb29

…ateVariablesInterface refactor

Private constants rework for NotifierEvent

5b479d3

magento#2: Code fixed according to Magento standards

8de4e30

Merge remote-tracking branch 'phoenix128/2.3-develop' into phoenix128…

cbaaf1d

…-2.3-develop

magento#2: Fixed composer packages name

d53729c

magento#2: License changed

a8ea46b

Stanislav Idolov and others added 12 commits October 18, 2019 14:44

Merge remote-tracking branch 'phoenix128/2.3-develop' into phoenix128…

68db8b9

…-2.3-develop

magento#2: Fixed controllers issue

53cd662

FIX declarative schema error

43009e6

Removed old layout file

94cd0d1

Conflicting contants

f6971e1

Wrong renaming

2539e75

Gitignore update

f89c486

Allow params in the notifier send method

c42c4c9

Amazon Event Bridge module for Notifier

423dd30

MOvod sendmessage to SPI

2ed29cb

FIX variables decorator issue

a77cabc

Avoid failures in security attached events

66c1dbb

sidolov approved these changes Oct 31, 2019

View reviewed changes

sidolov merged commit 572553c into magento:2.3-develop Oct 31, 2019

magento-engcom-team added Award: complex Award: advanced Award: special achievement Award: category of expertise Award: test coverage Award: devdocs update Award: bug fix labels Oct 31, 2019

mmansoor-magento pushed a commit that referenced this pull request Oct 22, 2020

Merge pull request #2 from magento-tsg/MC-34292

b67a37f

[Arrows] MC-34292: AdminCreateUserRoleWithReportsActionGroup needs to be refactored to be based in CE

magento-devops-reposync-svc pushed a commit that referenced this pull request May 24, 2022

Merge pull request #2 from magento-performance/CABPI-397-slopukhov

072d1dc

CABPI-397: Fix Failed Functional Tests CE Tests

Notifier Modules #2

Notifier Modules #2

Uh oh!

Conversation

phoenix128 commented Jul 31, 2019 • edited by sidolov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hostep commented Aug 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

phoenix128 commented Aug 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YevSent Aug 5, 2019

Choose a reason for hiding this comment

Uh oh!

phoenix128 Aug 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

magento-cicd2 commented Aug 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

phoenix128 commented Jul 31, 2019 •

edited by sidolov

Loading

hostep commented Aug 1, 2019 •

edited

Loading

phoenix128 Aug 26, 2019 •

edited

Loading

magento-cicd2 commented Aug 20, 2019 •

edited

Loading