MC-22950: Enable 2FA by default for Admins #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ability to skip configuration if there is a configured provider ready to use
- Fixed issues with wonky acl structure and redirect loop from bad permissions
- Fixed issue with 2fa permission - Fixed issue with skip configuration link
- 2fa secrets are now encrypted in the database
-Added modal informing users of dangerous configuration changes
-Added backend validation for some fields
- Addressed corner cases - Refactored a bit - Added label to duo auth screen
- Test cleanup and corner case fixes
- Fixed required option
- Added partial test coverage - static fixes
- More tests - Redundant code cleanup - Static cleanup
- New implementation for u2f keys
- Browser compatibility (*ahem* Safari *ahem*) - Minor template updates
- More compatibility changes - UI/UX enhancements
- Refactored configure process
- Removed redundant code - Fixed corner case with skipping configuration - fixed tests that don't cleanup
- Added patch to reset any existing u2f config
- Code review feedback - Removed extra code - Fixed ACL check for unconfigured site with disallowed user role - Moved session data into dedicated locations - Refactored userId's to user UserContext
- Removed uneeded property
- Fixed typo causing providers to not be selected
nathanjosiah
added
the
Component: 2FA
|
@nathanjosiah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
|
@nathanjosiah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
|
@nathanjosiah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
|
@nathanjosiah unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
AlexMaxHorkun
previously approved these changes
Apr 20, 2020
AlexMaxHorkun
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)